Skip to content

Replace delegate based server impl with call handler#102

Open
marcoferrer wants to merge 20 commits into
masterfrom
server-call-handler-impl
Open

Replace delegate based server impl with call handler#102
marcoferrer wants to merge 20 commits into
masterfrom
server-call-handler-impl

Conversation

@marcoferrer
Copy link
Copy Markdown
Owner

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 31, 2019

Codecov Report

❌ Patch coverage is 89.21569% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.29%. Comparing base (aad7b71) to head (b232741).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...oplus/coroutines/client/ClientResponseObservers.kt 80.55% 11 Missing and 10 partials ⚠️
.../krotoplus/coroutines/server/ServerCallHandlers.kt 95.08% 3 Missing and 3 partials ⚠️
...s/coroutines/server/DeferredCancellationHandler.kt 78.57% 1 Missing and 2 partials ⚠️
...oferrer/krotoplus/coroutines/client/ClientCalls.kt 95.12% 0 Missing and 2 partials ⚠️
...rer/krotoplus/coroutines/call/CallReadyObserver.kt 93.33% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (aad7b71) and HEAD (b232741). Click for more details.

HEAD has 99 uploads less than BASE
Flag BASE (aad7b71) HEAD (b232741)
100 1
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #102       +/-   ##
=============================================
- Coverage     88.07%   65.29%   -22.78%     
- Complexity       21       22        +1     
=============================================
  Files            16       19        +3     
  Lines           369      608      +239     
  Branches         50       75       +25     
=============================================
+ Hits            325      397       +72     
- Misses           25      183      +158     
- Partials         19       28        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcoferrer marcoferrer force-pushed the server-call-handler-impl branch from 51f2db5 to 9bd2cde Compare January 12, 2020 17:21
@marcoferrer marcoferrer force-pushed the server-call-handler-impl branch from 9bd2cde to 27e77d7 Compare January 12, 2020 17:47
@marcoferrer marcoferrer force-pushed the server-call-handler-impl branch from 30eb80f to 7e3ae1f Compare January 13, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant