-
-
Notifications
You must be signed in to change notification settings - Fork 94
Expand file tree
/
Copy pathfile-processor.ts
More file actions
446 lines (372 loc) · 14.4 KB
/
file-processor.ts
File metadata and controls
446 lines (372 loc) · 14.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
import { Herb } from "@herb-tools/node-wasm"
import { Linter } from "../linter.js"
import { rules } from "../rules.js"
import { loadCustomRules } from "../loader.js"
import { Config } from "@herb-tools/config"
import { Worker } from "node:worker_threads"
import { readFileSync, writeFileSync } from "node:fs"
import { resolve, dirname, join } from "node:path"
import { fileURLToPath } from "node:url"
import { availableParallelism } from "node:os"
import { colorize } from "@herb-tools/highlighter"
import { computeDiff, formatDiff } from "./diff.js"
import type { DiffHunk } from "./diff.js"
import type { Diagnostic } from "@herb-tools/core"
import type { FormatOption } from "./argument-parser.js"
import type { HerbConfigOptions } from "@herb-tools/config"
import type { WorkerInput, WorkerResult } from "./lint-worker.js"
import type { VersionSkippedRule } from "../linter.js"
export interface ProcessedFile {
filename: string
offense: Diagnostic
content: string
autocorrectable?: boolean
autofixDiff?: DiffHunk[]
}
export interface ProcessingContext {
projectPath?: string
configPath?: string
pattern?: string
fix?: boolean
fixUnsafe?: boolean
ignoreDisableComments?: boolean
linterConfig?: HerbConfigOptions['linter']
config?: Config
hasConfigFile?: boolean
loadCustomRules?: boolean
jobs?: number
}
export interface ProcessingResult {
totalErrors: number
totalWarnings: number
totalInfo: number
totalHints: number
totalIgnored: number
totalWouldBeIgnored?: number
filesWithOffenses: number
filesFixed: number
ruleCount: number
allOffenses: ProcessedFile[]
ruleOffenses: Map<string, { count: number, files: Set<string> }>
rulesSkippedByVersion: VersionSkippedRule[]
rulesDisabledByConfig: number
rulesNotEnabledByDefault: number
context?: ProcessingContext
}
/**
* Minimum number of files required to use parallel processing.
* Below this threshold, sequential processing is faster due to
* worker thread startup overhead (loading WASM, config, etc.).
*/
const PARALLEL_FILE_THRESHOLD = 10
export class FileProcessor {
private linter: Linter | null = null
private customRulesLoaded: boolean = false
private isRuleAutocorrectable(ruleName: string): boolean {
if (!this.linter) return false
const ruleClass = (this.linter as any).rules.find(
(rule: any) => rule.ruleName === ruleName
)
if (!ruleClass) return false
return ruleClass.autocorrectable === true
}
async processFiles(files: string[], formatOption: FormatOption = 'detailed', context?: ProcessingContext): Promise<ProcessingResult> {
const jobs = context?.jobs ?? 1
const shouldParallelize = jobs > 1 && files.length >= PARALLEL_FILE_THRESHOLD
if (shouldParallelize) {
return this.processFilesInParallel(files, jobs, formatOption, context)
}
return this.processFilesSequentially(files, formatOption, context)
}
private async processFilesSequentially(files: string[], formatOption: FormatOption = 'detailed', context?: ProcessingContext): Promise<ProcessingResult> {
let totalErrors = 0
let totalWarnings = 0
let totalInfo = 0
let totalHints = 0
let totalIgnored = 0
let totalWouldBeIgnored = 0
let filesWithOffenses = 0
let filesFixed = 0
let ruleCount = 0
const allOffenses: ProcessedFile[] = []
const ruleOffenses = new Map<string, { count: number, files: Set<string> }>()
if (!this.linter) {
let customRules = undefined
let customRuleInfo: Array<{ name: string, path: string }> = []
let customRuleWarnings: string[] = []
if (context?.loadCustomRules && !this.customRulesLoaded) {
try {
const result = await loadCustomRules({
baseDir: context.projectPath,
silent: formatOption === 'json'
})
customRules = result.rules
customRuleInfo = result.ruleInfo
customRuleWarnings = result.warnings
this.customRulesLoaded = true
if (customRules.length > 0 && formatOption !== 'json') {
const ruleText = customRules.length === 1 ? 'rule' : 'rules'
console.log(colorize(`\nLoaded ${customRules.length} custom ${ruleText}:`, "green"))
for (const { name, path } of customRuleInfo) {
const relativePath = context.projectPath ? path.replace(context.projectPath + '/', '') : path
console.log(colorize(` • ${name}`, "cyan") + colorize(` (${relativePath})`, "dim"))
}
if (customRuleWarnings.length > 0) {
console.log()
for (const warning of customRuleWarnings) {
console.warn(colorize(` ⚠ ${warning}`, "yellow"))
}
}
console.log()
}
} catch (error) {
if (formatOption !== 'json') {
console.warn(colorize(`Warning: Failed to load custom rules: ${error}`, "yellow"))
}
}
}
this.linter = Linter.from(Herb, context?.config, customRules)
}
for (const filename of files) {
const filePath = context?.projectPath ? resolve(context.projectPath, filename) : resolve(filename)
let content = readFileSync(filePath, "utf-8")
const lintResult = this.linter.lint(content, {
fileName: filename,
ignoreDisableComments: context?.ignoreDisableComments
})
if (ruleCount === 0) {
ruleCount = this.linter.getRuleCount()
}
if (context?.fix && lintResult.offenses.length > 0) {
const autofixResult = this.linter.autofix(content, {
fileName: filename,
ignoreDisableComments: context?.ignoreDisableComments
}, undefined, { includeUnsafe: context?.fixUnsafe })
if (autofixResult.fixed.length > 0) {
writeFileSync(filePath, autofixResult.source, "utf-8")
filesFixed++
if (formatOption !== 'json') {
console.log(`${colorize("✓", "brightGreen")} ${colorize(filename, "cyan")} - ${colorize(`Fixed ${autofixResult.fixed.length} ${autofixResult.fixed.length === 1 ? "offense" : "offenses"}`, "green")}`)
}
}
content = autofixResult.source
for (const offense of autofixResult.unfixed) {
allOffenses.push({
filename,
offense: offense,
content,
autocorrectable: this.isRuleAutocorrectable(offense.rule)
})
const ruleData = ruleOffenses.get(offense.rule) || { count: 0, files: new Set() }
ruleData.count++
ruleData.files.add(filename)
ruleOffenses.set(offense.rule, ruleData)
}
if (autofixResult.unfixed.length > 0) {
totalErrors += autofixResult.unfixed.filter(offense => offense.severity === "error").length
totalWarnings += autofixResult.unfixed.filter(offense => offense.severity === "warning").length
totalInfo += autofixResult.unfixed.filter(offense => offense.severity === "info").length
totalHints += autofixResult.unfixed.filter(offense => offense.severity === "hint").length
filesWithOffenses++
}
} else if (lintResult.offenses.length === 0) {
if (files.length === 1 && formatOption !== 'json') {
console.log(`${colorize("✓", "brightGreen")} ${colorize(filename, "cyan")} - ${colorize("No issues found", "green")}`)
}
} else {
for (const offense of lintResult.offenses) {
const autocorrectable = this.isRuleAutocorrectable(offense.rule)
let autofixDiff: DiffHunk[] | undefined
if (autocorrectable && formatOption !== "json") {
const previewResult = this.linter.previewAutofix(content, {
fileName: filename,
ignoreDisableComments: context?.ignoreDisableComments
}, [offense], { includeUnsafe: true })
if (previewResult.fixed.length > 0) {
autofixDiff = computeDiff(content, previewResult.source)
}
}
allOffenses.push({
filename,
offense: offense,
content,
autocorrectable,
autofixDiff,
})
const ruleData = ruleOffenses.get(offense.rule) || { count: 0, files: new Set() }
ruleData.count++
ruleData.files.add(filename)
ruleOffenses.set(offense.rule, ruleData)
}
totalErrors += lintResult.errors
totalWarnings += lintResult.warnings
totalInfo += lintResult.offenses.filter(o => o.severity === "info").length
totalHints += lintResult.offenses.filter(o => o.severity === "hint").length
filesWithOffenses++
}
totalIgnored += lintResult.ignored
if (lintResult.wouldBeIgnored) {
totalWouldBeIgnored += lintResult.wouldBeIgnored
}
}
const result: ProcessingResult = {
totalErrors,
totalWarnings,
totalInfo,
totalHints,
totalIgnored,
filesWithOffenses,
filesFixed,
ruleCount,
allOffenses,
ruleOffenses,
rulesSkippedByVersion: this.linter?.rulesSkippedByVersion ?? [],
rulesDisabledByConfig: this.linter?.rulesDisabledByConfig ?? 0,
rulesNotEnabledByDefault: this.linter?.rulesNotEnabledByDefault ?? 0,
context
}
if (totalWouldBeIgnored > 0) {
result.totalWouldBeIgnored = totalWouldBeIgnored
}
return result
}
private async processFilesInParallel(files: string[], jobs: number, formatOption: FormatOption, context?: ProcessingContext): Promise<ProcessingResult> {
const workerCount = Math.min(jobs, files.length)
const chunks = this.splitIntoChunks(files, workerCount)
const workerPath = this.resolveWorkerPath()
const configVersion = context?.config?.configVersion
const filterResult = Linter.filterRulesByConfig(rules, context?.config?.linter?.rules, configVersion)
const workerPromises = chunks.map(chunk => this.runWorker(workerPath, chunk, context))
const workerResults = await Promise.all(workerPromises)
for (const result of workerResults) {
if (result.error) {
throw new Error(`Worker error: ${result.error}`)
}
}
const aggregated = this.aggregateWorkerResults(workerResults, formatOption, context)
aggregated.rulesSkippedByVersion = filterResult.skippedByVersion
aggregated.rulesDisabledByConfig = filterResult.disabledByConfig
aggregated.rulesNotEnabledByDefault = filterResult.notEnabledByDefault
return aggregated
}
private resolveWorkerPath(): string {
try {
const currentDir = dirname(fileURLToPath(import.meta.url))
return join(currentDir, "lint-worker.js")
} catch {
return join(__dirname, "lint-worker.js")
}
}
private splitIntoChunks(files: string[], chunkCount: number): string[][] {
const chunks: string[][] = Array.from({ length: chunkCount }, () => [])
for (let i = 0; i < files.length; i++) {
chunks[i % chunkCount].push(files[i])
}
return chunks.filter(chunk => chunk.length > 0)
}
private runWorker(workerPath: string, files: string[], context?: ProcessingContext): Promise<WorkerResult> {
return new Promise((resolve, reject) => {
const workerData: WorkerInput = {
files,
projectPath: context?.projectPath || process.cwd(),
configPath: context?.configPath,
fix: context?.fix || false,
fixUnsafe: context?.fixUnsafe || false,
ignoreDisableComments: context?.ignoreDisableComments || false,
loadCustomRules: context?.loadCustomRules || false,
}
const worker = new Worker(workerPath, { workerData })
worker.on("message", (result: WorkerResult) => {
resolve(result)
})
worker.on("error", (error) => {
reject(error)
})
worker.on("exit", (code) => {
if (code !== 0) {
reject(new Error(`Worker exited with code ${code}`))
}
})
})
}
private aggregateWorkerResults(results: WorkerResult[], formatOption: FormatOption, context?: ProcessingContext): ProcessingResult {
let totalErrors = 0
let totalWarnings = 0
let totalInfo = 0
let totalHints = 0
let totalIgnored = 0
let totalWouldBeIgnored = 0
let filesWithOffenses = 0
let filesFixed = 0
let ruleCount = 0
const allOffenses: ProcessedFile[] = []
const ruleOffenses = new Map<string, { count: number, files: Set<string> }>()
for (const result of results) {
totalErrors += result.totalErrors
totalWarnings += result.totalWarnings
totalInfo += result.totalInfo
totalHints += result.totalHints
totalIgnored += result.totalIgnored
totalWouldBeIgnored += result.totalWouldBeIgnored
filesWithOffenses += result.filesWithOffenses
filesFixed += result.filesFixed
if (result.ruleCount > 0) {
ruleCount = result.ruleCount
}
for (const offense of result.offenses) {
allOffenses.push({
filename: offense.filename,
offense: offense.offense,
content: offense.content,
autocorrectable: offense.autocorrectable
})
}
for (const [rule, data] of result.ruleOffenses) {
const existing = ruleOffenses.get(rule) || { count: 0, files: new Set<string>() }
existing.count += data.count
for (const file of data.files) {
existing.files.add(file)
}
ruleOffenses.set(rule, existing)
}
if (formatOption !== 'json') {
for (const fixMessage of result.fixMessages) {
const [filename, countStr] = fixMessage.split("\t")
const count = parseInt(countStr, 10)
console.log(`${colorize("\u2713", "brightGreen")} ${colorize(filename, "cyan")} - ${colorize(`Fixed ${count} ${count === 1 ? "offense" : "offenses"}`, "green")}`)
}
}
}
const processingResult: ProcessingResult = {
totalErrors,
totalWarnings,
totalInfo,
totalHints,
totalIgnored,
filesWithOffenses,
filesFixed,
ruleCount,
allOffenses,
ruleOffenses,
rulesSkippedByVersion: [],
rulesDisabledByConfig: 0,
rulesNotEnabledByDefault: 0,
context
}
if (totalWouldBeIgnored > 0) {
processingResult.totalWouldBeIgnored = totalWouldBeIgnored
}
return processingResult
}
/**
* Returns the default number of parallel jobs based on available CPU cores.
* Returns 1 if parallelism detection fails.
*/
static defaultJobs(): number {
try {
return availableParallelism()
} catch {
return 1
}
}
}