Upgrade Prism to v1.8.0 - #1067
Merged
Merged
Conversation
github-actions
Bot
added
documentation
Owner
Author
|
Quite a few interesting failures 🤔 Gonna let this sit for a second and come back later |
marcoroth
marked this pull request as draft
January 16, 2026 12:00
marcoroth
marked this pull request as ready for review
January 17, 2026 09:45
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prism 1.8.0 (ruby/prism#3827) changed how the
closing_locis populated for unclosed blocks. Previously it wasNULLfor unclosed blocks, but now it's always set (pointing to body content). This broke our detection logic that relied on checking ifclosing_locwas empty.https://github.com/ruby/prism/releases/tag/v1.8.0