Skip to content

t1491: Add WebKit for SwiftUI (WWDC25) to Swift development guide#2841

Closed
johnwaldo wants to merge 1 commit into
marcusquinn:mainfrom
johnwaldo:chore/webkit-swiftui-docs
Closed

t1491: Add WebKit for SwiftUI (WWDC25) to Swift development guide#2841
johnwaldo wants to merge 1 commit into
marcusquinn:mainfrom
johnwaldo:chore/webkit-swiftui-docs

Conversation

@johnwaldo

@johnwaldo johnwaldo commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add WebKit for SwiftUI coverage from WWDC 2025 Session 231 to mobile-app-dev/swift.md
  • New table row, new section, and platform decision update — 17 lines added, 0 removed
  • No personal elements, no custom skill references, no secrets

Closes #2840

Summary by CodeRabbit

  • Documentation
    • Added guidance for embedding web content within SwiftUI applications using WebKit integration
    • Documented new APIs for web content interaction, navigation controls, and custom URL scheme handling
    • Updated deployment target requirements and compatibility specifications

Add WebKit for SwiftUI coverage from WWDC 2025 Session 231:
- New row in Native Capabilities table for WebKit
- New 'Hybrid Content' section covering WebView, WebPage, URLSchemeHandler,
  callJavaScript, NavigationDeciding, and scroll/find view modifiers
- Note in platform decision section that Swift now has first-class web
  content embedding
@coderabbitai

coderabbitai Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cfcec69f-80dd-4f9d-bc47-2369bf416963

📥 Commits

Reviewing files that changed from the base of the PR and between 4a2fdcb and cc79831.

📒 Files selected for processing (1)
  • .agents/mobile-app-dev/swift.md

Walkthrough

Adds documentation for WebKit for SwiftUI (WWDC 2025) to the Swift development guide, covering hybrid content capabilities, new APIs for web view integration, JavaScript bridging, and deployment target requirements for iOS 26+/macOS 26+/visionOS 26+.

Changes

Cohort / File(s) Summary
Swift Development Documentation
.agents/mobile-app-dev/swift.md
Added "Hybrid native + web content apps" platform decision rationale, Web content row to Native Capabilities table, and comprehensive "Hybrid Content (WebKit for SwiftUI)" section covering WebView, WebPage Observable, JavaScript interop, URL scheme handlers, navigation controls, and scroll modifiers. Specifies iOS/macOS/visionOS 26+ minimum deployment targets.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🚀 WebKit flows through SwiftUI's gates,
Web content meets native—no more waits,
WWDC wisdom in markdown laid bare,
Hybrid apps now get first-class care! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding WebKit for SwiftUI documentation to the Swift development guide, referencing the WWDC25 source.
Linked Issues check ✅ Passed All three objectives from issue #2840 are met: platform decision update for hybrid apps, Native Capabilities table row for Web content, and comprehensive Hybrid Content section with all specified APIs and view modifiers.
Out of Scope Changes check ✅ Passed All changes align with issue #2840 scope: documentation additions to .agents/mobile-app-dev/swift.md for WebKit for SwiftUI coverage with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Swift development guide by integrating information about WebKit for SwiftUI, a new framework from WWDC 2025. The update provides developers with guidance on leveraging this technology for embedding web content and building hybrid applications, ensuring the documentation remains current with the latest Apple platform advancements.

Highlights

  • WebKit for SwiftUI Integration: Added comprehensive coverage of WebKit for SwiftUI, introduced at WWDC 2025, to the Swift development guide.
  • Guide Updates: Incorporated a new table row for web content, a dedicated section detailing WebKit for SwiftUI's features and APIs, and an update to platform decision guidance for hybrid apps.
  • Hybrid App Development: Expanded the guide to include considerations for building hybrid native + web content applications using the new WebKit for SwiftUI framework.
Changelog
  • .agents/mobile-app-dev/swift.md
    • Added a new bullet point under 'tools' to include hybrid native + web content apps as a use case for Swift.
    • Inserted a new row into the platform decision table, recommending 'WebKit for SwiftUI' for 'Web content' with details on its capabilities.
    • Created a new section titled 'Hybrid Content (WebKit for SwiftUI)' which describes its introduction, use cases, key APIs (e.g., WebView(url:), WebPage, callJavaScript(), URLSchemeHandler), and platform requirements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully adds comprehensive documentation for WebKit for SwiftUI, including its use cases, key APIs, and platform requirements, enhancing the Swift development guide. The new content is well-structured and clearly explains the new capabilities introduced at WWDC 2025.

Note: Security Review has been skipped due to the limited scope of the PR.

@alex-solovyev

Copy link
Copy Markdown
Collaborator

This PR is from an external contributor (@johnwaldo). Auto-merge is disabled for external PRs — a maintainer must review and merge manually.

@alex-solovyev alex-solovyev added the external-contributor PR from external contributor, requires maintainer review label Mar 4, 2026
@alex-solovyev

Copy link
Copy Markdown
Collaborator

This PR is superseded by #2848, which covers the same t1491 task (WebKit for SwiftUI docs) and was opened by a maintainer on the same branch. Closing in favour of #2848.

@alex-solovyev

Copy link
Copy Markdown
Collaborator

Closing as duplicate — superseded by maintainer PR #2848 on the same branch (chore/webkit-swiftui-docs) for the same task t1491.

@marcusquinn

Copy link
Copy Markdown
Owner

Reopened: TODO.md still has this as [ ] (open) and no merged PR was found. The issue was prematurely closed by a commit keyword. TODO.md is the source of truth for task state.


aidevops.sh v3.31.19 plugin for OpenCode v1.17.13 Overall, 119d 18h since this issue was created.

@marcusquinn

Copy link
Copy Markdown
Owner

Maintainer review needed: this PR is DIRTY (merge conflicts with the default branch) and does not meet the auto-rebase or auto-close criteria.

Reason: supersession-check:fully_superseded:current branch has no diff against origin/main, and base contains 55/55 deliverable term(s)

Options:

  • Rebase manually: git fetch origin && git rebase origin/$(git symbolic-ref --short refs/remotes/origin/HEAD | sed 's|origin/||') (or --strategy-option=union when TODO.md is the culprit).
  • Close as superseded: gh pr close 2841 --delete-branch.
  • Opt out of future sweeps: add the do-not-close label.

This comment is posted once per cooldown window (1800s) so the sweep stays quiet.

Triggered by pulse-dirty-pr-sweep.sh (t2350 / GH#19948).


aidevops.sh v3.31.19 automated scan.

@alex-solovyev

Copy link
Copy Markdown
Collaborator

Rebase needed — PR has merge conflicts and no origin:* label

This PR has merge conflicts against the default branch and lacks both origin:interactive and origin:worker labels. The pulse merge pass treats it as the label-agnostic stuck state (t3193) and surfaces it here with a one-shot rebase nudge.

To resolve

git fetch origin
git checkout chore/webkit-swiftui-docs
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease

Or use the GitHub web UI's Update branch button if the conflicts are trivial enough.

Why this PR slipped through the existing nudges

The existing rebase-nudge family (_post_rebase_nudge_on_interactive_conflicting, _post_rebase_nudge_on_contributor_conflicting, _post_rebase_nudge_on_worker_conflicting) keys on the origin:* labels. PRs created without those labels — typically docs/migration commits made directly via the web UI or via a worker that didn't apply its origin label — were silently re-evaluated every cycle without surfacing.

Posted automatically by pulse-merge-stuck.sh (t3193 / GH#21895).


aidevops.sh v3.31.22 automated scan.

@marcusquinn

Copy link
Copy Markdown
Owner

CI repair feedback routed to issue #2840

This worker PR had terminal failed CI checks. The check details have been appended
to the linked issue body so the next worker can address them.

Terminal failed checks:

  • Label PR from Conventional Commit: failure — check URL
  • SonarCloud Analysis: failure — check URL
  • 🤖 Monitor & Auto-Fix Code Quality: failure — check URL

Closed by deterministic merge pass (pulse-merge.sh).

@marcusquinn marcusquinn closed this Jul 9, 2026
@marcusquinn marcusquinn added the ci-feedback-routed Worker PR with failing CI routed to linked issue for re-dispatch label Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-feedback-routed Worker PR with failing CI routed to linked issue for re-dispatch external-contributor PR from external contributor, requires maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t1491: Add WebKit for SwiftUI (WWDC25) to Swift development guide

3 participants