[codex] fix binary request bodies#112
Draft
maxvaljan wants to merge 1 commit into
Draft
Conversation
|
@maxvaljan is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NitroRequest.bodyBytestoArrayBufferand regenerate Nitrogen bindingsArrayBuffer/typed-array request bodies through to native instead of dropping themArrayBufferand typed-array request bodiesRoot Cause
The public fetch API and docs support
ArrayBufferand typed-array request bodies, butbuildNitroRequestandbuildNitroRequestPuresetbodyBytestoundefined. The native request paths also could not upload binary bodies: iOS ignoredreq.bodyBytes, and Android sent a one-byte placeholder.Notes
Cold-start prefetch entries are JSON-backed, so this PR does not try to persist raw binary prefetch bodies through
bodyBytes. String and form-data prefetch behavior remains unchanged.Validation
bun --cwd packages/react-native-nitro-fetch test -- src/__tests__/fetch.test.ts src/__tests__/Response.test.tsbun --cwd packages/react-native-nitro-fetch typecheckbun --cwd packages/react-native-nitro-fetch nitrogenPackage-wide
bun --cwd packages/react-native-nitro-fetch lintstill reports existing tracked.jsformatting/no-undef issues outside this diff.