fix: correct query result memory estimate

chrispader · chrispader · commit a0c803d1a2b8 · 2026-07-14T15:08:40.000+02:00
diff --git a/packages/react-native-nitro-sqlite/cpp/hybridObjects/HybridNitroSQLiteQueryResult.cpp b/packages/react-native-nitro-sqlite/cpp/hybridObjects/HybridNitroSQLiteQueryResult.cpp
@@ -19,7 +19,7 @@ namespace {
   size_t getRowExternalMemorySize(const SQLiteQueryResultRow& row) {
     size_t bucketMemory = row.bucket_count() * sizeof(void*);
     constexpr size_t nodePadding = 24;
-    size_t nodesMemory = row.size() * (sizeof(std::pair<std::string, SQLiteValue>) * nodePadding);
+    size_t nodesMemory = row.size() * (sizeof(std::pair<std::string, SQLiteValue>) + nodePadding);
     return bucketMemory + nodesMemory;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ namespace {`
`19`	`19`	`size_t getRowExternalMemorySize(const SQLiteQueryResultRow& row) {`
`20`	`20`	`size_t bucketMemory = row.bucket_count() * sizeof(void*);`
`21`	`21`	`constexpr size_t nodePadding = 24;`
`22`		`- size_t nodesMemory = row.size() * (sizeof(std::pair<std::string, SQLiteValue>) * nodePadding);`
	`22`	`+ size_t nodesMemory = row.size() * (sizeof(std::pair<std::string, SQLiteValue>) + nodePadding);`
`23`	`23`	`return bucketMemory + nodesMemory;`
`24`	`24`	`}`
`25`	`25`