Skip to content

Commit 0849a57

Browse files
authored
fix(android): remove isRenderscriptDebuggable deprecation warning (#901)
1 parent 08104ea commit 0849a57

6 files changed

Lines changed: 40 additions & 77 deletions

File tree

.claude/commands/pr.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ When activated, create a pull request for the current branch:
3030

3131
5. **Create the PR**:
3232
```bash
33-
gh pr create --title "<title>" --body "<body>" --base main
33+
gh pr create --title "<title>" --body "<body>" --base main --assignee @me
3434
```
3535

3636
6. **Report the PR URL** to the user

.github/workflows/e2e-android-test.yml

Lines changed: 30 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,15 @@ on:
1313
- 'cpp/**'
1414
- 'nitrogen/**'
1515
- 'src/**'
16+
- 'packages/react-native-quick-crypto/android/**'
1617
push:
1718
branches: [main]
1819
paths:
1920
- 'example/**'
2021
- 'cpp/**'
2122
- 'nitrogen/**'
2223
- 'src/**'
24+
- 'packages/react-native-quick-crypto/android/**'
2325

2426
jobs:
2527
e2e-tests-android:
@@ -60,6 +62,17 @@ jobs:
6062
distribution: 'corretto'
6163
java-version: '17'
6264

65+
- name: Install System Dependencies
66+
run: |
67+
sudo apt-get update
68+
sudo apt-get install -y libssl-dev pkg-config
69+
70+
- name: Setup Android SDK
71+
uses: android-actions/setup-android@v3
72+
73+
- name: Install Dependencies
74+
run: bun install
75+
6376
- name: Restore Gradle cache
6477
uses: actions/cache/restore@v5
6578
with:
@@ -70,25 +83,27 @@ jobs:
7083
example/android/build
7184
example/android/app/.cxx
7285
example/android/app/build
86+
packages/react-native-quick-crypto/android/.cxx
87+
packages/react-native-quick-crypto/android/build
88+
node_modules/.bun/react-native-nitro-modules*/node_modules/react-native-nitro-modules/android/.cxx
89+
node_modules/.bun/react-native-nitro-modules*/node_modules/react-native-nitro-modules/android/build
7390
key: ${{ runner.os }}-gradle
7491

75-
- name: Install System Dependencies
76-
run: |
77-
sudo apt-get update
78-
sudo apt-get install -y libssl-dev pkg-config
79-
80-
- name: Setup Android SDK
81-
uses: android-actions/setup-android@v3
82-
83-
- name: Install Dependencies
84-
run: bun install
85-
8692
- name: Build Android App
8793
working-directory: ./example/android
8894
run: |
8995
echo "Building Android app (x86_64 only)..."
9096
./gradlew :app:assembleDebug -PreactNativeArchitectures=x86_64 --build-cache > $HOME/output/android-build.log 2>&1
9197
98+
- name: Run Gradle Lint
99+
working-directory: ./example/android
100+
run: ./gradlew :react-native-quick-crypto:lintDebug -PreactNativeArchitectures=x86_64
101+
102+
- name: Parse Gradle Lint Report
103+
uses: yutailang0119/action-android-lint@v4
104+
with:
105+
report-path: packages/react-native-quick-crypto/android/build/reports/lint-results-debug.xml
106+
92107
- name: Install Maestro CLI
93108
run: |
94109
export MAESTRO_VERSION=2.0.10
@@ -172,6 +187,10 @@ jobs:
172187
example/android/build
173188
example/android/app/.cxx
174189
example/android/app/build
190+
packages/react-native-quick-crypto/android/.cxx
191+
packages/react-native-quick-crypto/android/build
192+
node_modules/.bun/react-native-nitro-modules*/node_modules/react-native-nitro-modules/android/.cxx
193+
node_modules/.bun/react-native-nitro-modules*/node_modules/react-native-nitro-modules/android/build
175194
key: ${{ runner.os }}-gradle
176195

177196
- name: Exit with Test Result

.github/workflows/e2e-ios-test.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,15 @@ on:
1313
- 'cpp/**'
1414
- 'nitrogen/**'
1515
- 'src/**'
16+
- 'packages/react-native-quick-crypto/ios/**'
1617
push:
1718
branches: [main]
1819
paths:
1920
- 'example/**'
2021
- 'cpp/**'
2122
- 'nitrogen/**'
2223
- 'src/**'
24+
- 'packages/react-native-quick-crypto/ios/**'
2325

2426
jobs:
2527
e2e-tests-ios:
@@ -70,6 +72,7 @@ jobs:
7072
with:
7173
path: |
7274
example/ios/Pods
75+
~/.cocoapods/repos
7376
~/Library/Caches/CocoaPods
7477
packages/react-native-quick-crypto/ios/libsodium-stable
7578
packages/react-native-quick-crypto/deps
@@ -221,6 +224,7 @@ jobs:
221224
with:
222225
path: |
223226
example/ios/Pods
227+
~/.cocoapods/repos
224228
~/Library/Caches/CocoaPods
225229
packages/react-native-quick-crypto/ios/libsodium-stable
226230
packages/react-native-quick-crypto/deps

.github/workflows/validate-android.yml

Lines changed: 0 additions & 63 deletions
This file was deleted.

example/ios/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2811,7 +2811,7 @@ SPEC CHECKSUMS:
28112811
MMKVCore: f2dd4c9befea04277a55e84e7812f930537993df
28122812
NitroMmkv: afbc5b2fbf963be567c6c545aa1efcf6a9cec68e
28132813
NitroModules: 11bba9d065af151eae51e38a6425e04c3b223ff3
2814-
QuickCrypto: f94f1a51756d344996aed0b277fe66b72b46d617
2814+
QuickCrypto: fa022cc8d5eec5c0ff4e701284143e08fce09a5e
28152815
RCT-Folly: 846fda9475e61ec7bcbf8a3fe81edfcaeb090669
28162816
RCTDeprecation: c4b9e2fd0ab200e3af72b013ed6113187c607077
28172817
RCTRequired: e97dd5dafc1db8094e63bc5031e0371f092ae92a
@@ -2883,6 +2883,6 @@ SPEC CHECKSUMS:
28832883
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
28842884
Yoga: 11c9686a21e2cd82a094a723649d9f4507200fb0
28852885

2886-
PODFILE CHECKSUM: 36c6d27eaa3ccd179672014ad06e56eb12f2a223
2886+
PODFILE CHECKSUM: dc7b787857f5c9edee237d5b88e746b4790f1bbc
28872887

28882888
COCOAPODS: 1.15.2

packages/react-native-quick-crypto/android/build.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,9 @@ android {
7979
buildFeatures {
8080
buildConfig true
8181
prefab true
82+
// Explicitly disable RenderScript (deprecated since Android 12, removed in AGP 9.0)
83+
// to suppress 'isRenderscriptDebuggable is obsolete' warning. See #802.
84+
renderScript = false
8285
}
8386

8487
packagingOptions {

0 commit comments

Comments
 (0)