fix: add react-native-quick-base64 as peer dependency (#903)

Author: boorad

README.md

@@ -50,7 +50,7 @@ There is a benchmark suite in the Example app in this repo that has benchmarks o
 </h3>
 
 ```sh
-bun add react-native-quick-crypto react-native-nitro-modules
+bun add react-native-quick-crypto react-native-nitro-modules react-native-quick-base64
 cd ios && pod install
 ```
 

docs/content/docs/api/install.mdx

@@ -55,3 +55,4 @@ const buf = Buffer.from('hello');
 1.  **`global.Buffer`**: Re-exported from [`@craftzdog/react-native-buffer`](https://github.com/craftzdog/react-native-buffer). You can also import it directly: `import { Buffer } from 'react-native-quick-crypto'`.
 2.  **`global.crypto`**: Points to `QuickCrypto`.
 3.  **`global.process`**: Adds `process.nextTick` (mapped to `setImmediate`).
+4.  **`global.base64ToArrayBuffer` / `global.base64FromArrayBuffer`**: Native base64 encoding/decoding from [`react-native-quick-base64`](https://github.com/craftzdog/react-native-quick-base64).

docs/content/docs/introduction/quick-start.mdx

@@ -98,22 +98,22 @@ Follow these steps to integrate Quick Crypto into your React Native project.
     <Tabs items={['npm', 'yarn', 'pnpm', 'bun']}>
       <Tab value="npm">
         ```bash
-        npm install react-native-quick-crypto react-native-nitro-modules
+        npm install react-native-quick-crypto react-native-nitro-modules react-native-quick-base64
         ```
       </Tab>
       <Tab value="yarn">
         ```bash
-        yarn add react-native-quick-crypto react-native-nitro-modules
+        yarn add react-native-quick-crypto react-native-nitro-modules react-native-quick-base64
         ```
       </Tab>
       <Tab value="pnpm">
         ```bash
-        pnpm add react-native-quick-crypto react-native-nitro-modules
+        pnpm add react-native-quick-crypto react-native-nitro-modules react-native-quick-base64
         ```
       </Tab>
       <Tab value="bun">
         ```bash
-        bun add react-native-quick-crypto react-native-nitro-modules
+        bun add react-native-quick-crypto react-native-nitro-modules react-native-quick-base64
         ```
       </Tab>
     </Tabs>

example/src/hooks/useTestsList.ts

@@ -6,6 +6,8 @@ import '../tests/blake3/blake3_tests';
 import '../tests/cipher/cipher_tests';
 import '../tests/cipher/chacha_tests';
 import '../tests/cipher/xsalsa20_tests';
+import '../tests/dh/dh_tests';
+import '../tests/ecdh/ecdh_tests';
 import '../tests/hash/hash_tests';
 import '../tests/hmac/hmac_tests';
 import '../tests/hkdf/hkdf_tests';
@@ -17,8 +19,6 @@ import '../tests/keys/public_cipher';
 import '../tests/keys/sign_verify_streaming';
 import '../tests/keys/sign_verify_oneshot';
 import '../tests/pbkdf2/pbkdf2_tests';
-import '../tests/ecdh/ecdh_tests';
-import '../tests/dh/dh_tests';
 import '../tests/random/random_tests';
 import '../tests/scrypt/scrypt_tests';
 import '../tests/subtle/deriveBits';

example/src/tests/subtle/import_export.ts

@@ -1,9 +1,15 @@
 import { assert, expect } from 'chai';
-import {
-  fromByteArray,
-  toByteArray,
-  trimBase64Padding,
-} from 'react-native-quick-base64';
+
+declare global {
+  // eslint-disable-next-line no-var
+  var base64ToArrayBuffer: (
+    base64: string,
+    removeLinebreaks?: boolean,
+  ) => ArrayBuffer;
+  // eslint-disable-next-line no-var
+  var base64FromArrayBuffer: (buffer: ArrayBuffer, urlSafe?: boolean) => string;
+}
+
 import type {
   CryptoKey,
   CryptoKeyPair,
@@ -72,14 +78,19 @@ function base64ToArrayBuffer(val: string): ArrayBuffer {
   while (cleaned.endsWith('.')) {
     cleaned = cleaned.slice(0, -1);
   }
-  const arr = toByteArray(cleaned);
-  return binaryLikeToArrayBuffer(arr);
+  return global.base64ToArrayBuffer(cleaned);
 }
 
-// TODO: add in `url` from react-native-quick-base64 when 2.1.1 is released
 function arrayBufferToBase64(buffer: ArrayBuffer, urlSafe: boolean = false) {
-  const bytes = new Uint8Array(buffer);
-  return fromByteArray(bytes, urlSafe);
+  return global.base64FromArrayBuffer(buffer, urlSafe);
+}
+
+function trimBase64Padding(str: string): string {
+  return str.replace(/[.=]{1,2}$/, '');
+}
+
+function toByteArray(b64: string): Uint8Array {
+  return new Uint8Array(global.base64ToArrayBuffer(b64));
 }
 
 const SUITE = 'subtle.importKey/exportKey';

packages/react-native-quick-crypto/package.json

@@ -75,7 +75,6 @@
   "dependencies": {
     "@craftzdog/react-native-buffer": "6.1.0",
     "events": "3.3.0",
-    "react-native-quick-base64": "2.2.2",
     "readable-stream": "4.5.2",
     "safe-buffer": "^5.2.1",
     "util": "0.12.5"
@@ -97,6 +96,7 @@
     "react": "*",
     "react-native": "*",
     "react-native-nitro-modules": ">=0.29.1",
+    "react-native-quick-base64": ">=2.1.0",
     "expo": ">=48.0.0",
     "expo-build-properties": "*"
   },

packages/react-native-quick-crypto/src/index.ts

@@ -53,6 +53,10 @@ export const install = () => {
 
   // @ts-expect-error subtle isn't fully implemented and Cryptokey is missing
   global.crypto = QuickCrypto;
+
+  // Install base64 globals (base64ToArrayBuffer, base64FromArrayBuffer)
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
+  require('react-native-quick-base64');
 };
 
 // random, cipher, hash use nextTick