Skip to content

Commit 536d9a3

Browse files
committed
docs: address additional PR feedback
- Change Simple Random Strings to suggest react-native-get-random-values for random-only use cases - Update comparison title from JSI to Nitro - Add benchmark philosophy note explaining comparison context
1 parent da727cb commit 536d9a3

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

docs/content/docs/introduction/comparison.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ RNQC is designed to be the faster, more complete alternative to existing solutio
2222

2323
## Visual Comparison
2424

25-
### Standard Bridge vs. RNQC JSI
25+
### Standard Bridge vs. RNQC Nitro
2626

2727
```mermaid
2828
sequenceDiagram
@@ -72,7 +72,7 @@ JSI allows us to define "Hybrid Objects" that can spawn their own C++ threads. W
7272
Proof is in the numbers. We benchmarked RNQC against standard JS implementations (`browserify`) and other native libraries.
7373

7474
<Callout type="info">
75-
**Note**: These are results from real tests, but actual performance may vary depending on real-life situations.
75+
**Benchmark Philosophy**: These comparisons are not meant to disparage pure JavaScript libraries. Libraries like `@noble/hashes` and `@noble/curves` perform exceptionally well in browser and Node.js environments. However, React Native lacks Node.js crypto APIs, so these benchmarks demonstrate the performance advantage of native implementations when pure JS is the only alternative on mobile.
7676
</Callout>
7777

7878
**Environment**: iPhone 15 Pro, iOS 17.

docs/content/docs/introduction/what-is-rnqc.mdx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ title: What is RNQC?
33
description: The philosophy behind RNQC
44
---
55

6-
import { Check, X } from 'lucide-react';
6+
import { Check, X, HelpCircle } from 'lucide-react';
77

88

99

@@ -65,5 +65,7 @@ Unlike the legacy Bridge, which relies on asynchronous JSON message passing (slo
6565
| **Web3 / Blockchain** | <Check className="text-green-500" /> | Essential for wallet generation, signing transactions, and hashing (Keccak/SHA) securely and quickly. |
6666
| **Auth (JWT/Jose)** | <Check className="text-green-500" /> | Drastically speeds up token verification and signing compared to JS-only implementations. |
6767
| **End-to-End Encryption** | <Check className="text-green-500" /> | Using standard algorithms (AES-GCM, RSA) on the native thread prevents UI jank. |
68-
| **Simple Random Strings** | <Check className="text-green-500" /> | `randomBytes` is cryptographically secure (CSPRNG), unlike `Math.random()`. |
68+
| **Simple Random Strings** | <HelpCircle className="text-yellow-500" /> | If you only need random numbers, consider [`react-native-get-random-values`](https://github.com/LinusU/react-native-get-random-values) for a lighter
69+
70+
alternative. Use RNQC if you need other crypto operations too. |
6971
| **UI-Only Apps** | <X className="text-red-500" /> | If your app has zero security or hashing requirements, you probably don't need this. |

0 commit comments

Comments
 (0)