stack -> heap buffer for final()

Author: boorad

example/ios/Podfile.lock

@@ -1940,7 +1940,7 @@ SPEC CHECKSUMS:
   fmt: 10c6e61f4be25dc963c36bd73fc7b1705fe975be
   glog: 08b301085f15bcbb6ff8632a8ebaf239aae04e6a
   hermes-engine: 46f1ffbf0297f4298862068dd4c274d4ac17a1fd
-  NitroModules: 3a58d9bc70815a0d5de4476ed6a36eff05a6a0ae
+  NitroModules: c36d6f656038a56beb1b1bcab2d0252d71744013
   OpenSSL-Universal: b60a3702c9fea8b3145549d421fdb018e53ab7b4
   QuickCrypto: 11878b44cfc77fad2ea8f387a16e315841651305
   RCT-Folly: 84578c8756030547307e4572ab1947de1685c599

example/src/tests/cipher/cipher_tests.ts

@@ -54,12 +54,12 @@ test(SUITE, 'cipher - buffers', async () => {
   );
 });
 
-// // update/final
-// ciphers.forEach(cipherName => {
-//   test(SUITE, `cipher - non-stream - ${cipherName}`, async () => {
-//     roundtrip(cipherName as CipherType, key, iv, plaintext);
-//   });
-// });
+// update/final
+ciphers.forEach(cipherName => {
+  test(SUITE, `cipher - non-stream - ${cipherName}`, async () => {
+    roundtrip(cipherName as CipherType, key, iv, plaintext);
+  });
+});
 
 function roundtrip(
   cipherName: CipherType,
@@ -68,8 +68,8 @@ function roundtrip(
   payload: string,
 ) {
   const cipher: Cipher = createCipheriv(cipherName, lKey, lIv, {});
-  let ciph = cipher.update(payload, 'utf8', 'buffer');
-  ciph = Buffer.concat([ciph, cipher.final('buffer')]);
+  let ciph = cipher.update(payload, 'utf8', 'buffer') as Buffer;
+  ciph = Buffer.concat([ciph, cipher.final()]);
 
   const decipher: Decipher = createDecipheriv(cipherName, lKey, lIv, {});
   let deciph = decipher.update(ciph, 'buffer', 'utf8');

packages/react-native-quick-crypto/cpp/cipher/HybridCipher.cpp

@@ -104,13 +104,14 @@ HybridCipher::final() {
   }
 
   int finalLen = 0;
-  unsigned char tempBuf[EVP_MAX_BLOCK_LENGTH];
+  uint8_t* tempBuf = new uint8_t[EVP_MAX_BLOCK_LENGTH];
 
   // Finalize the encryption/decryption
   if (EVP_CipherFinal_ex(
         ctx,
         tempBuf,
         &finalLen) != 1) {
+    delete[] tempBuf;
     throw std::runtime_error("Failed to finalize cipher: " +
       std::to_string(ERR_get_error()));
   }
@@ -119,7 +120,7 @@ HybridCipher::final() {
   return std::make_shared<NativeArrayBuffer>(
     tempBuf,
     finalLen,
-    nullptr
+    [=]() { delete[] tempBuf; }
   );
 }
 

packages/react-native-quick-crypto/src/cipher.ts

@@ -10,12 +10,6 @@ import type {
   CipherGCMOptions,
   CipherOCBOptions,
   CipherOCBTypes,
-  DecipherGCM,
-  DecipherOCB,
-  DecipherCCM,
-  CipherCCM,
-  CipherOCB,
-  CipherGCM,
 } from 'crypto'; // @types/node
 import type { Cipher as NativeCipher } from './specs/cipher.nitro';
 import { binaryLikeToArrayBuffer } from './utils';
@@ -184,7 +178,7 @@ class Cipheriv extends CipherCommon {
   }
 }
 
-type Cipher = CipherCCM | CipherOCB | CipherGCM | Cipheriv;
+type Cipher = Cipheriv;
 
 class Decipheriv extends CipherCommon {
   constructor(
@@ -203,26 +197,26 @@ class Decipheriv extends CipherCommon {
   }
 }
 
-type Decipher = DecipherCCM | DecipherOCB | DecipherGCM | Decipheriv;
+type Decipher = Decipheriv;
 
 export function createDecipheriv(
   algorithm: CipherCCMTypes,
   key: BinaryLikeNode,
   iv: BinaryLike,
   options: CipherCCMOptions,
-): DecipherCCM;
+): Decipher;
 export function createDecipheriv(
   algorithm: CipherOCBTypes,
   key: BinaryLikeNode,
   iv: BinaryLike,
   options: CipherOCBOptions,
-): DecipherOCB;
+): Decipher;
 export function createDecipheriv(
   algorithm: CipherGCMTypes,
   key: BinaryLikeNode,
   iv: BinaryLike,
   options?: CipherGCMOptions,
-): DecipherGCM;
+): Decipher;
 export function createDecipheriv(
   algorithm: CipherType,
   key: BinaryLikeNode,
@@ -252,19 +246,19 @@ export function createCipheriv(
   key: BinaryLikeNode,
   iv: BinaryLike,
   options: CipherCCMOptions,
-): CipherCCM;
+): Cipher;
 export function createCipheriv(
   algorithm: CipherOCBTypes,
   key: BinaryLikeNode,
   iv: BinaryLike,
   options: CipherOCBOptions,
-): CipherOCB;
+): Cipher;
 export function createCipheriv(
   algorithm: CipherGCMTypes,
   key: BinaryLikeNode,
   iv: BinaryLike,
   options?: CipherGCMOptions,
-): CipherGCM;
+): Cipher;
 export function createCipheriv(
   algorithm: CipherType,
   key: BinaryLikeNode,