Skip to content

Commit 9e34a72

Browse files
authored
feat(perf): Use jsi::String::createFromAscii() if possible (#1035)
1 parent fb014b5 commit 9e34a72

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

packages/react-native-quick-crypto/cpp/utils/HybridUtils.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -261,13 +261,13 @@ facebook::jsi::Value HybridUtils::bufferToJsiString(facebook::jsi::Runtime& runt
261261
const auto* data = reinterpret_cast<const uint8_t*>(buffer->data() + offset);
262262

263263
if (encoding == "hex") {
264-
return facebook::jsi::String::createFromUtf8(runtime, encodeHex(data, length));
264+
return facebook::jsi::String::createFromAscii(runtime, encodeHex(data, length));
265265
}
266266
if (encoding == "base64") {
267-
return facebook::jsi::String::createFromUtf8(runtime, encodeBase64(data, length));
267+
return facebook::jsi::String::createFromAscii(runtime, encodeBase64(data, length));
268268
}
269269
if (encoding == "base64url") {
270-
return facebook::jsi::String::createFromUtf8(runtime, encodeBase64Url(data, length));
270+
return facebook::jsi::String::createFromAscii(runtime, encodeBase64Url(data, length));
271271
}
272272
if (encoding == "utf8" || encoding == "utf-8") {
273273
return facebook::jsi::String::createFromUtf8(runtime, data, length);
@@ -280,7 +280,7 @@ facebook::jsi::Value HybridUtils::bufferToJsiString(facebook::jsi::Runtime& runt
280280
for (auto& c : result) {
281281
c &= 0x7F;
282282
}
283-
return facebook::jsi::String::createFromUtf8(runtime, result);
283+
return facebook::jsi::String::createFromAscii(runtime, result);
284284
}
285285
if (encoding == "utf16le") {
286286
return createUtf16LeString(runtime, data, length);

0 commit comments

Comments
 (0)