feat: subtle.generateKey for ec (#784)

Author: boorad

.github/ISSUE_TEMPLATE/BUILD_ERROR.yml

@@ -41,7 +41,6 @@ body:
           "react-native": "^0.74.3",
           "react-native-quick-crypto": "^0.7.1",
           "@craftzdog/react-native-buffer": "^6.0.5",
-          "react-native-fast-encoder": "^0.1.12",
           "react-native-quick-base64": "^2.1.2",
           ...
         },

bun.lock

@@ -342,8 +342,8 @@ This document attempts to describe the implementation status of Crypto APIs/Inte
 ### `CryptoKeyPair` algorithms
 | Algorithm           | Status |
 | ---------           | :----: |
-| `ECDH`              | ❌ |
-| `ECDSA`             | ❌ |
+| `ECDH`              | ✅ |
+| `ECDSA`             | ✅ |
 | `Ed25519`           | ❌ |
 | `Ed448`             | ❌ |
 | `ML-DSA-44`         | ❌ |

docs/implementation-coverage.md

@@ -1331,29 +1331,7 @@ PODS:
     - React-RCTFBReactNativeSpec
     - ReactCommon/turbomodule/core
     - ReactNativeDependencies
-  - react-native-fast-encoder (0.2.0):
-    - hermes-engine
-    - RCTRequired
-    - RCTTypeSafety
-    - React-Core
-    - React-Core-prebuilt
-    - React-debug
-    - React-Fabric
-    - React-featureflags
-    - React-graphics
-    - React-ImageManager
-    - React-jsi
-    - React-NativeModulesApple
-    - React-RCTFabric
-    - React-renderercss
-    - React-rendererdebug
-    - React-utils
-    - ReactCodegen
-    - ReactCommon/turbomodule/bridging
-    - ReactCommon/turbomodule/core
-    - ReactNativeDependencies
-    - Yoga
-  - react-native-quick-base64 (2.2.1):
+  - react-native-quick-base64 (2.2.2):
     - React-Core
   - react-native-safe-area-context (5.6.1):
     - hermes-engine
@@ -1884,8 +1862,7 @@ DEPENDENCIES:
   - React-logger (from `../../node_modules/react-native/ReactCommon/logger`)
   - React-Mapbuffer (from `../../node_modules/react-native/ReactCommon`)
   - React-microtasksnativemodule (from `../../node_modules/react-native/ReactCommon/react/nativemodule/microtasks`)
-  - react-native-fast-encoder (from `../../node_modules/react-native-fast-encoder`)
-  - react-native-quick-base64 (from `../node_modules/react-native-quick-base64`)
+  - react-native-quick-base64 (from `../../node_modules/react-native-quick-base64`)
   - react-native-safe-area-context (from `../../node_modules/react-native-safe-area-context`)
   - React-NativeModulesApple (from `../../node_modules/react-native/ReactCommon/react/nativemodule/core/platform/ios`)
   - React-oscompat (from `../../node_modules/react-native/ReactCommon/oscompat`)
@@ -2002,10 +1979,8 @@ EXTERNAL SOURCES:
     :path: "../../node_modules/react-native/ReactCommon"
   React-microtasksnativemodule:
     :path: "../../node_modules/react-native/ReactCommon/react/nativemodule/microtasks"
-  react-native-fast-encoder:
-    :path: "../../node_modules/react-native-fast-encoder"
   react-native-quick-base64:
-    :path: "../node_modules/react-native-quick-base64"
+    :path: "../../node_modules/react-native-quick-base64"
   react-native-safe-area-context:
     :path: "../../node_modules/react-native-safe-area-context"
   React-NativeModulesApple:
@@ -2116,8 +2091,7 @@ SPEC CHECKSUMS:
   React-logger: a1c9c8dfc56711d06a21109b55908e177113e554
   React-Mapbuffer: bc36232966c55d5b1cbef3b84cb97c4317fa4403
   React-microtasksnativemodule: cbabfedcf6c2984e59d07f9ab553f3d277599b1b
-  react-native-fast-encoder: f65266038936a5ade3a54d34755fce3c7bd92483
-  react-native-quick-base64: 7b7f689c9b7b4d40916bf5d27e211db1040abac5
+  react-native-quick-base64: 6568199bb2ac8e72ecdfdc73a230fbc5c1d3aac4
   react-native-safe-area-context: 42a1b4f8774b577d03b53de7326e3d5757fe9513
   React-NativeModulesApple: 055e2d1417c663e7a26fc0847609f503e626e9e1
   React-oscompat: 8f2893713639e12c7558750a9f7de3f08ac255b0

example/ios/Podfile.lock

@@ -36,9 +36,8 @@
     "react": "19.1.0",
     "react-native": "0.81.1",
     "react-native-bouncy-checkbox": "4.1.2",
-    "react-native-fast-encoder": "0.2.0",
     "react-native-nitro-modules": "0.29.1",
-    "react-native-quick-base64": "2.2.1",
+    "react-native-quick-base64": "2.2.2",
     "react-native-quick-crypto": "workspace:*",
     "react-native-safe-area-context": "^5.2.2",
     "react-native-screens": "4.15.4",

example/package.json

@@ -30,10 +30,6 @@ import aes_gcm_fixtures from '../../fixtures/aes_gcm';
 import { assertThrowsAsync } from '../util';
 import { ab2str } from 'react-native-quick-crypto';
 
-import RNFE from 'react-native-fast-encoder';
-// @ts-expect-error polyfill types are wonky
-globalThis.TextEncoder = () => RNFE;
-
 export type RsaEncryptDecryptTestVector = {
   name: string;
   publicKey: Buffer | null;

example/src/tests/subtle/encrypt_decrypt.ts

@@ -5,6 +5,8 @@ import { expect } from 'chai';
 
 const encoder = new TextEncoder();
 
+const SUITE = 'subtle.sign/verify';
+
 // // Test Sign/Verify RSASSA-PKCS1-v1_5
 // {
 //   async function test(data) {
@@ -53,7 +55,7 @@ const encoder = new TextEncoder();
 //   test('hello world').then(common.mustCall());
 // }
 
-test('subtle.sign_verify', 'ECDSA P-384', async () => {
+test(SUITE, 'ECDSA P-384', async () => {
   const pair = await subtle.generateKey(
     { name: 'ECDSA', namedCurve: 'P-384' },
     true,
@@ -78,7 +80,7 @@ test('subtle.sign_verify', 'ECDSA P-384', async () => {
   ).to.equal(true);
 });
 
-test('subtle.sign_verify', 'ECDSA with HashAlgorithmIdentifier', async () => {
+test(SUITE, 'ECDSA with HashAlgorithmIdentifier', async () => {
   const pair = await subtle.generateKey(
     { name: 'ECDSA', namedCurve: 'P-256' },
     true,

example/src/tests/subtle/sign_verify.ts

@@ -15,6 +15,7 @@ add_library(
   ../cpp/cipher/XSalsa20Cipher.cpp
   ../cpp/cipher/ChaCha20Cipher.cpp
   ../cpp/cipher/ChaCha20Poly1305Cipher.cpp
+  ../cpp/ec/HybridEcKeyPair.cpp
   ../cpp/ed25519/HybridEdKeyPair.cpp
   ../cpp/hash/HybridHash.cpp
   ../cpp/hmac/HybridHmac.cpp
@@ -33,6 +34,7 @@ include(${CMAKE_SOURCE_DIR}/../nitrogen/generated/android/QuickCrypto+autolinkin
 include_directories(
   "src/main/cpp"
   "../cpp/cipher"
+  "../cpp/ec"
   "../cpp/ed25519"
   "../cpp/hash"
   "../cpp/hmac"
@@ -42,8 +44,6 @@ include_directories(
   "../cpp/utils"
   "../deps/fastpbkdf2"
   "../deps/ncrypto/include"
-  "../build/includes" # flattened Nitro Modules headers
-  "../../../node_modules/react-native/ReactCommon/jsi"
 )
 
 # Third party libraries (Prefabs)

packages/react-native-quick-crypto/android/CMakeLists.txt

@@ -40,12 +40,14 @@ class HybridCipherFactory : public HybridCipherFactorySpec {
           // Pass tag length (default 16 if not present)
           size_t tag_len = args.authTagLen.has_value() ? static_cast<size_t>(args.authTagLen.value()) : 16;
           std::static_pointer_cast<OCBCipher>(cipherInstance)->init(args.cipherKey, args.iv, tag_len);
+          EVP_CIPHER_free(cipher);
           return cipherInstance;
         }
         case EVP_CIPH_CCM_MODE: {
           cipherInstance = std::make_shared<CCMCipher>();
           cipherInstance->setArgs(args);
           cipherInstance->init(args.cipherKey, args.iv);
+          EVP_CIPHER_free(cipher);
           return cipherInstance;
         }
         case EVP_CIPH_STREAM_CIPHER: {
@@ -55,12 +57,14 @@ class HybridCipherFactory : public HybridCipherFactorySpec {
             cipherInstance = std::make_shared<ChaCha20Cipher>();
             cipherInstance->setArgs(args);
             cipherInstance->init(args.cipherKey, args.iv);
+            EVP_CIPHER_free(cipher);
             return cipherInstance;
           }
           if (cipherName == "chacha20-poly1305") {
             cipherInstance = std::make_shared<ChaCha20Poly1305Cipher>();
             cipherInstance->setArgs(args);
             cipherInstance->init(args.cipherKey, args.iv);
+            EVP_CIPHER_free(cipher);
             return cipherInstance;
           }
         }
@@ -69,6 +73,7 @@ class HybridCipherFactory : public HybridCipherFactorySpec {
           cipherInstance = std::make_shared<HybridCipher>();
           cipherInstance->setArgs(args);
           cipherInstance->init(args.cipherKey, args.iv);
+          EVP_CIPHER_free(cipher);
           return cipherInstance;
         }
       }