fix: default RSA-PSS saltLength to RSA_PSS_SALTLEN_MAX_SIGN#1029
Merged
Conversation
…erify Match Node.js behavior: when padding === RSA_PKCS1_PSS_PADDING and saltLength is undefined, default to RSA_PSS_SALTLEN_MAX_SIGN before forwarding to native. Closes #1006.
Verify that omitting saltLength with RSA_PKCS1_PSS_PADDING produces a signature that round-trips both with no explicit saltLength and with the explicit RSA_PSS_SALTLEN_MAX_SIGN constant.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🤖 End-to-End Test Results - AndroidStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
Contributor
🤖 End-to-End Test Results - iOSStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
padding: RSA_PKCS1_PSS_PADDINGis set onsign/verifybutsaltLengthis omitted, RNQC was passingundefinedstraight through to OpenSSL — which falls back to digest length (-1). Node.js defaults this case toRSA_PSS_SALTLEN_MAX_SIGN(-2), so signatures produced by RNQC were not interoperable with Node's defaults.This PR mirrors Node's behavior in
lib/internal/crypto/sig.js(getSaltLength): whenpadding === RSA_PKCS1_PSS_PADDINGandsaltLength === undefined, default toRSA_PSS_SALTLEN_MAX_SIGN. Behavior is unchanged whensaltLengthis set explicitly.Changes
packages/react-native-quick-crypto/src/keys/signVerify.ts: addgetSaltLength()helper applying the Node.js default; wire it intoSign.signandVerify.verify.example/src/tests/keys/sign_verify_oneshot.ts: new test verifying that an unspecified-salt sign round-trips and matches an explicitRSA_PSS_SALTLEN_MAX_SIGNverify.example/src/tests/keys/sign_verify_streaming.ts: same coverage for the streamingcreateSign/createVerifyAPI.Testing
RSA-PSS defaults saltLength to MAX_SIGN when undefinedpass in bothkeys.sign/verifysuites.saltLengthstill pass (no regression).Fixes #1006