fix(deps): upgrade react-native-quick-base64 to v3#1046
Merged
Conversation
v2.x throws `Base64Module.install is not a function` on React Native
New Architecture (default in Expo SDK 54+) because the legacy bridge
install method is not exposed via NativeModules under bridgeless mode.
v3.0.0 ships a Codegen TurboModule and dropped the install side effect.
Replace the `require('react-native-quick-base64')` side effect in
QuickCrypto's `install()` with explicit calls to v3's `toByteArray` /
`fromByteArray`, assigning `global.base64ToArrayBuffer` and
`global.base64FromArrayBuffer` directly. Declare those globals in the
package so consumers get the types. Bump `@craftzdog/react-native-
buffer` to 6.1.2 (v3-compatible) and pin all touched versions per the
new code-typescript rule (no caret/tilde ranges).
Fixes the `Base64Module.install is not a function` runtime error
reported on vanilla Expo SDK 54/55 setups.
Library package.json may use ranges so consumers aren't blocked on exact-version updates. Only the example app needs deterministic pins. - Loosen @craftzdog/react-native-buffer to ^6.1.2 - Loosen react-native-quick-base64 peerDep to >=3.0.0 - Scope exact-pin rule to example app's package.json
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🤖 End-to-End Test Results - iOSStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
Contributor
🤖 End-to-End Test Results - AndroidStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
react-native-quick-base64from v2.2.2 to v3.0.0 for New Architecture support, and updates the polyfill ininstall()to work with v3's breaking API change.v3 no longer auto-installs
global.base64ToArrayBuffer/global.base64FromArrayBufferon import, and only exports named functions (toByteArray,fromByteArray,byteLength,trimBase64Padding). The polyfill now wires the globals through those named exports so the public surface used bysubtle.importKey/subtle.exportKeyis preserved.Changes
react-native-quick-base64to3.0.0(example app + peerDep)@craftzdog/react-native-bufferto6.1.2(transitively requires base64 ^3.0.0)global.base64ToArrayBuffer/global.base64FromArrayBufferinsideinstall()using v3's named exportsPodfile.lock(v3 brings in the full New Architecture pod set)BUILD_ERROR.ymlissue template examplepackage.jsonmay use ranges (^,>=)Testing
bun tsccleanNotes
This PR obsoletes #1045 — the rule it referenced ("pin everything") has been scoped to the example app only, since library
package.jsonshould keep ranges for consumer flexibility.Closes #1045