feat(hkdf): implement HKDF with WebCrypto support and native C++ backend#848
Merged
Conversation
Includes: - Native HKDF implementation (C++, Nitro, Android/iOS) - WebCrypto HKDF integration in subtle.ts - UI Fix: Custom Checkbox component replacing Switch - iOS Fix: Update REACT_NATIVE_PATH in project.pbxproj
Contributor
Author
|
@boorad need a quick review. Also noticed something weird — every time I run the iOS app, Xcode auto-changes the pod path from |
boorad
requested changes
Dec 7, 2025
boorad
reviewed
Dec 7, 2025
boorad
left a comment
boorad
left a comment
Collaborator
There was a problem hiding this comment.
couple more, pretty close 🚀
boorad
reviewed
Dec 7, 2025
boorad
left a comment
boorad
left a comment
Collaborator
There was a problem hiding this comment.
Forgot one, about your XCode issue.
Also, why are the tests failing? You can look in the actions and download build logs for the e2e tests.
boorad
reviewed
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: HKDF Implementation & Runtime Stability Fixes
Summary
This PR implements full HKDF support (WebCrypto & Native) and resolves critical runtime crashes in the example app. It also restores the original UI appearance by replacing incompatible dependencies.
✨ Features
subtle.crypto.deriveKeyandsubtle.crypto.deriveBits.📊 Implementation Results
🐛 Bugs Fixed & Solutions
1. Runtime Crash:
TypeError: property is not writableprocess.versionandprocess.nextTickwas attempting to overwrite read-only properties in strict mode or specific environments.Object.definePropertywith checks to prevent overwriting existing read-only properties in src/index.ts.2. UI Crash:
TypeError: Cannot read property 'default' of undefinedreact-native-bouncy-checkboxcausing immediate crashes on render.react-native-vector-icons. This restores the original look and feel without the stability issues.🧪 Verification
bun lintpasses with no errors.