Skip to content

fix: cast getRandomValues result and fix CI tsc error detection #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boorad merged 1 commit into from
Mar 3, 2026
Merged

fix: cast getRandomValues result and fix CI tsc error detection #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/validate-js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ jobs:

- name: Run TypeScript # Reviewdog tsc errorformat: %f:%l:%c - error TS%n: %m
run: |
bun tsc | reviewdog -name="tsc" -efm="%f(%l,%c): error TS%n: %m" -reporter="github-pr-review" -filter-mode="nofilter" -fail-on-error -tee
set -o pipefail
bun tsc 2>&1 | sed 's/^[^ ]* typescript: //' | reviewdog -name="tsc" -efm="%f(%l,%c): error TS%n: %m" -reporter="github-pr-review" -filter-mode="nofilter" -fail-on-error -tee
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
10 changes: 5 additions & 5 deletions example/src/tests/subtle/wrap_unwrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ test(SUITE, 'wrap/unwrap AES-256 with AES-KW', async () => {
);

// Verify keys are functionally identical
const plaintext = getRandomValues(new Uint8Array(32));
const plaintext = getRandomValues(new Uint8Array(32)) as Uint8Array;
const iv = getRandomValues(new Uint8Array(12));

const ct1 = await subtle.encrypt(
Expand Down Expand Up @@ -184,7 +184,7 @@ test(SUITE, 'wrap/unwrap with AES-CBC', async () => {
['encrypt', 'decrypt'],
);

const plaintext = getRandomValues(new Uint8Array(32));
const plaintext = getRandomValues(new Uint8Array(32)) as Uint8Array;
const gcmIv = getRandomValues(new Uint8Array(12));

const ct = await subtle.encrypt(
Expand Down Expand Up @@ -237,7 +237,7 @@ test(SUITE, 'wrap/unwrap with AES-OCB', async () => {
['encrypt', 'decrypt'],
);

const plaintext = getRandomValues(new Uint8Array(32));
const plaintext = getRandomValues(new Uint8Array(32)) as Uint8Array;
const gcmIv = getRandomValues(new Uint8Array(12));

const ct = await subtle.encrypt(
Expand Down Expand Up @@ -343,7 +343,7 @@ test(SUITE, 'wrap/unwrap with RSA-OAEP', async () => {
['encrypt', 'decrypt'],
);

const plaintext = getRandomValues(new Uint8Array(32));
const plaintext = getRandomValues(new Uint8Array(32)) as Uint8Array;
const iv = getRandomValues(new Uint8Array(12));

const ct = await subtle.encrypt(
Expand Down Expand Up @@ -396,7 +396,7 @@ test(SUITE, 'wrap/unwrap with ChaCha20-Poly1305', async () => {
['encrypt', 'decrypt'],
);

const plaintext = getRandomValues(new Uint8Array(32));
const plaintext = getRandomValues(new Uint8Array(32)) as Uint8Array;
const gcmIv = getRandomValues(new Uint8Array(12));

const ct = await subtle.encrypt(
Expand Down
Loading