fix: pass pod options to custom containers#1804
Open
infocusmodereal wants to merge 1 commit into
Open
Conversation
infocusmodereal
marked this pull request as ready for review
June 16, 2026 15:04
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pass
mariadbPodOptoptions through custom MariaDB init and sidecar container construction.This makes custom containers use the same volumeMount option set as the Pod template being built. In particular, special builder paths that disable data-plane or service-account volumes no longer risk leaving custom containers with a
serviceaccountvolumeMount that has no matching Pod volume.Why
We hit a Galera recovery failure on
mariadb-operator25.10.2where the generated recovery Job was rejected by Kubernetes:The immediate Galera recovery Job path is already safer in
25.10.3+because Galera init/recovery Jobs exclude custom init and sidecar containers. This PR hardens the shared builder path so custom containers consistently respect pod options when they are included by any specialized Pod/Job builder.Fixes #1803.
Validation
go test ./pkg/builder