Try writing again to the channel if LIBSSH2_ERROR_EAGAIN is returned.#3
Open
yo-bur wants to merge 1 commit intomarianafranco:masterfrom
Open
Try writing again to the channel if LIBSSH2_ERROR_EAGAIN is returned.#3yo-bur wants to merge 1 commit intomarianafranco:masterfrom
yo-bur wants to merge 1 commit intomarianafranco:masterfrom
Conversation
| do { | ||
| i = libssh2_channel_write(channel, buf, len); | ||
| i = LIBSSH2_ERROR_EAGAIN; | ||
| while (i == LIBSSH2_ERROR_EAGAIN) { |
Owner
There was a problem hiding this comment.
This can cause an infinite loop, blocking the tunnel on write.
The correct way to handle this is to check if the socket is alive before sending it again: https://stackoverflow.com/a/9811061/2052076
Some code examples that I found:
https://github.com/allisrc/libgit2-allisrc/blob/62ab0e1fc2a471db960b0bd881aab116b350a961/src/transports/ssh.c#L266
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
LIBSSH2_ERROR_EAGAINis returned forlibssh2_channel_write, retry writing the data.