fix(test): clean up worker fixture listeners

Author: Light2Dark

docs/adr/0004-isolated-parser-execution.md

@@ -241,7 +241,7 @@ A representative local Node 24 / Chromium 149 / arm64 macOS sample recorded:
 | Core-only fixture | 24,056 B | 7,497 B |
 | PostgreSQL transitive worker graph | 321,156 B | 67,396 B |
 | BigQuery transitive worker graph | 225,309 B | 50,389 B |
-| Complete worker fixture | 549,885 B | 118,160 B |
+| Complete worker fixture | 549,893 B | 118,170 B |
 
 The core module trace contained no `node-sql-parser` module. No dialect
 resource loaded before explicit construction. A single static module worker

test/worker-placement/README.md

@@ -11,7 +11,7 @@ can run offline after a clean root CI install.
 
 The minified Vite 8 single-worker baseline is 67,396 gzip bytes for the
 PostgreSQL transitive graph, 50,389 gzip bytes for the BigQuery transitive
-graph, and 118,160 gzip/549,885 raw bytes for the complete worker build output.
+graph, and 118,170 gzip/549,893 raw bytes for the complete worker build output.
 The PostgreSQL and BigQuery figures each include their transitive shared
 chunks; the report also identifies those shared chunks explicitly. The
 fail-closed ceilings include small explicit headroom over that measured

test/worker-placement/src/workers.js

@@ -8,11 +8,13 @@ const REQUEST_TIMEOUT_MS = 10_000;
 function request(worker, requestValue) {
   return new Promise((resolve, reject) => {
     const startedAt = performance.now();
-    const timeout = setTimeout(() => {
-      reject(new Error(`Worker request ${requestValue.id} timed out`));
-    }, REQUEST_TIMEOUT_MS);
-    const onError = (event) => {
+    const cleanup = () => {
       clearTimeout(timeout);
+      worker.removeEventListener("error", onError);
+      worker.removeEventListener("message", onMessage);
+    };
+    const onError = (event) => {
+      cleanup();
       reject(
         new Error(
           event.message ||
@@ -24,14 +26,16 @@ function request(worker, requestValue) {
       if (event.data?.id !== requestValue.id) {
         return;
       }
-      clearTimeout(timeout);
-      worker.removeEventListener("error", onError);
-      worker.removeEventListener("message", onMessage);
+      cleanup();
       resolve({
         response: event.data,
         roundTripMs: performance.now() - startedAt,
       });
     };
+    const timeout = setTimeout(() => {
+      cleanup();
+      reject(new Error(`Worker request ${requestValue.id} timed out`));
+    }, REQUEST_TIMEOUT_MS);
     worker.addEventListener("error", onError, { once: true });
     worker.addEventListener("message", onMessage);
     worker.postMessage(requestValue);
@@ -40,11 +44,13 @@ function request(worker, requestValue) {
 
 function waitForReady(worker) {
   return new Promise((resolve, reject) => {
-    const timeout = setTimeout(() => {
-      reject(new Error("Parser worker ready handshake timed out"));
-    }, REQUEST_TIMEOUT_MS);
-    const onError = (event) => {
+    const cleanup = () => {
       clearTimeout(timeout);
+      worker.removeEventListener("error", onError);
+      worker.removeEventListener("message", onMessage);
+    };
+    const onError = (event) => {
+      cleanup();
       reject(
         new Error(event.message || "Parser worker startup failed"),
       );
@@ -53,11 +59,13 @@ function waitForReady(worker) {
       if (event.data?.kind !== "ready") {
         return;
       }
-      clearTimeout(timeout);
-      worker.removeEventListener("error", onError);
-      worker.removeEventListener("message", onMessage);
+      cleanup();
       resolve(event.data);
     };
+    const timeout = setTimeout(() => {
+      cleanup();
+      reject(new Error("Parser worker ready handshake timed out"));
+    }, REQUEST_TIMEOUT_MS);
     worker.addEventListener("error", onError, { once: true });
     worker.addEventListener("message", onMessage);
   });