Commit a6f6c04
authored
chore: establish vNext quality foundation (#170)
Establishes the next-major engineering foundation before production
architecture changes. Adds the research and implementation plans, split
unit/browser configs, honest aggregate coverage ratchets, 95%
changed-code coverage, governed known failures, strict vNext typing,
clean builds, deterministic packed-consumer validation, Node floor
coverage, and release-gate parity.\n\nValidated locally: lint,
integrity, all TypeScript scopes, 587 unit tests plus one governed
expected failure, aggregate and changed coverage, Chromium browser
smoke, packed consumer/runtime parse, demo build, actionlint, and two
independent adversarial review loops.
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Sets up the vNext quality foundation with strict typing, split
unit/browser tests, honest coverage gates (aggregate + changed-code),
governed known failures, and deterministic package smoke tests that
preserve the `pnpm` version. Hardens CI/release and unblocks the next
major architecture work.
- **New Features**
- CI: pin Node 20.19.0 and `pnpm` 10.28.2 with version checks; disable
Node-managed PM version enforcement; add concurrency with
cancel-in-progress; fetch full git history; add lint and test integrity
gates; split unit and headless browser runs; enforce aggregate and
changed-code coverage.
- Release: add a compatibility job that runs `pnpm pack` and a consumer
smoke test; preserve and verify `pnpm` 10.28.2 across the smoke path;
`autofix.yml` also runs on `dev-refactor`.
- Known failures governed via `test/known-failures.json` with owner and
expiry.
- Added vNext docs: `SQL_EDITOR_RESEARCH.md` and `implementation.md`.
- **Refactors**
- Split TS configs and typecheck scripts for source, legacy tests, vNext
tests, and demo; vNext tests use stricter rules.
- Extracted `vitest` configs; `vite.config.ts` now only builds the demo.
- Minor ESM/typing fixes in demo and tests; export test now uses `pnpm
pack`.
<sup>Written for commit ebbeb2f.
Summary will update on new commits.</sup>
<a
href="https://cubic.dev/pr/marimo-team/codemirror-sql/pull/170?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>
<!-- End of auto-generated description by cubic. -->1 parent ca19200 commit a6f6c04
28 files changed
Lines changed: 3645 additions & 93 deletions
File tree
- .github/workflows
- demo
- scripts
- src
- __tests__
- sql/__tests__
- test
- package-smoke
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
11 | 44 | | |
12 | 45 | | |
13 | 46 | | |
| |||
27 | 60 | | |
28 | 61 | | |
29 | 62 | | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
30 | 69 | | |
31 | 70 | | |
32 | 71 | | |
33 | | - | |
34 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
35 | 83 | | |
36 | 84 | | |
37 | 85 | | |
| |||
76 | 124 | | |
77 | 125 | | |
78 | 126 | | |
79 | | - | |
| 127 | + | |
80 | 128 | | |
81 | 129 | | |
82 | 130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
11 | 17 | | |
12 | 18 | | |
13 | 19 | | |
| |||
22 | 28 | | |
23 | 29 | | |
24 | 30 | | |
| 31 | + | |
| 32 | + | |
25 | 33 | | |
26 | 34 | | |
27 | 35 | | |
| |||
38 | 46 | | |
39 | 47 | | |
40 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
41 | 52 | | |
42 | 53 | | |
43 | 54 | | |
44 | | - | |
45 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
46 | 65 | | |
47 | 66 | | |
48 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
49 | 71 | | |
50 | 72 | | |
51 | 73 | | |
52 | 74 | | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
53 | 147 | | |
54 | 148 | | |
55 | 149 | | |
| |||
0 commit comments