add dialect and refactor sql parser#11
Closed
Light2Dark wants to merge 1 commit into
Closed
Conversation
mscolnick
reviewed
Aug 4, 2025
| }), | ||
| sqlExtension({ | ||
| // Parser definition | ||
| sqlParser: new SqlParser({ dialect: "PostgresQL" }), |
Contributor
There was a problem hiding this comment.
i don't think we need to separate this from each config.
you can still do:
const sqlParser = new SqlParser({ dialect: "PostgresQL" }),
linterConfig: {sqlParser},
gutterConfig: {sqlParser},and you still get great composition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you need to create an sql parser / don't create one and use the default.
We pass in the dialect to the parser, so it can lint correctly.