feat: add Dremio SQL dialect#129
Merged
Light2Dark merged 1 commit intoMay 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new CodeMirror SQL dialect for Dremio and exposes it through the public dialect exports, with docs and tests updated accordingly.
Changes:
- Exported
DremioDialectfromsrc/dialects/index.ts - Added new
src/dialects/dremio.tsdefining Dremio keywords/types and dialect spec - Updated README and tests to list/validate the new dialect
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/dialects/index.ts | Exposes DremioDialect via the dialect barrel export |
| src/dialects/dremio.ts | Implements Dremio SQL dialect spec (keywords, types, quoting/comment rules) |
| src/tests/index.test.ts | Extends export snapshot and adds a Dremio dialect sanity test |
| README.md | Documents Dremio as an additional supported dialect |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
corleyma
force-pushed
the
corleyma/add-dremio-dialect
branch
from
May 27, 2026 20:42
f3c1a93 to
69de960
Compare
Light2Dark
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Dremio SQL dialect export with:
The keyword/type lists are based on Dremio's SQL reference docs.
Test Plan
pnpm test --run src/__tests__/index.test.tspnpm typecheckpnpm build