feat(vnext): add catalog search cache policy#196
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Light2Dark
marked this pull request as ready for review
July 25, 2026 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Catalog completion needs to reuse proven results without allowing stale pages, same-epoch loading transitions, remounted editors, or cache pressure to bypass epoch authority. This keeps the package-private scheduler, policy state, and observer lifecycle coherent before session composition and the public adapter are added.
Verification
Summary by cubic
Adds a bounded, epoch-aware cache for catalog search to reuse “ready” pages without serving stale data, and introduces refresh leases to prevent duplicate provider work.
New Features
SqlCatalogSearchPolicyStore: exact-key cache for ready pages with epoch-scoped invalidation.MAX_CATALOG_POLICY_STORE_ENTRIES(256) andMAX_CATALOG_POLICY_STORE_RETAINED_BYTES(2 MiB).relation-catalog-search-workwith fail-closed loading/retry gates.retainForRefresh) and single-shot availability dispatch with reentrancy safety.DEFAULT_CATALOG_REFRESH_LEASE_MS = 1000.hasLiveSubscription(scope)on the epoch coordinator.Migration
SqlCatalogEpochCoordinator, implementhasLiveSubscription(scope).undefined.refreshLeaseMsvia search-work options; no other changes required.Written for commit 803afd1. Summary will update on new commits.