feat(vnext): expose session relation completion#197
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Light2Dark
marked this pull request as ready for review
July 25, 2026 14:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqlDocumentSession.complete()andonDidChange()kind: "relation"item discriminantWhy
The lower catalog scheduler and parser-independent query-site work were not yet usable through the public session. This slice connects those layers without exposing coordinator identities, epochs, timers, or CodeMirror state. It gives adapters a bounded local-first response and an explicit revision event when catalog evidence becomes usable.
Catalog scope is treated as a live connection incarnation. Loading, partial, paginated, failed, overloaded, and timed-out evidence remains explicit, so unresolved marimo metadata cannot be mistaken for a complete empty catalog.
Evidence
Summary by cubic
Exposes a session-based, framework-independent relation completion API with deterministic CTE + catalog suggestions and clear change events. Aligns CI bundle budgets for both the core and the worker fixture to match the new relation service.
New Features
SqlDocumentSession.complete(request)returnsSqlCompletionResultwithkind: "relation"items.SqlDocumentSession.onDidChange(listener)emitsSqlSessionChangeEventwhen catalog evidence becomes usable.createSqlLanguageService({ catalog, completion: { catalogResponseBudgetMs } })to configure a catalog and timing.@marimo-team/codemirror-sql/vnext; added unit tests and a 10 KiB session completion benchmark.Migration
SqlRelationCompletionItem→SqlCompletionItemandSqlRelationCompletionList→SqlCompletionList.SqlCompletionItem.Written for commit c66cffc. Summary will update on new commits.