pod overrides now work as expected - #7
Merged
Conversation
corev1.PodSpec has attributes that are not omitempty (presuambly because they are mandatory) which meant that the override spec would have nil on those attributes, resulting in a broken podspec.
dmadisetti
approved these changes
Mar 30, 2026
dmadisetti
left a comment
dmadisetti
left a comment
Member
There was a problem hiding this comment.
@bittrance Thanks! Will get a release out today
dmadisetti
added a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corev1.PodSpec has attributes that are not omitempty (presuambly because they are mandatory) which meant that the override spec would have nil on those attributes, resulting in a broken podspec.
This PR also adds a symbolic e2e test because overrides was not tested at all in a real cluster.