feat(altair): add inline option to SVG renderer for opt-out support

Author: daizutabi

marimo/_output/formatters/altair_formatters.py

@@ -80,7 +80,10 @@ def _show_chart(chart: AltairChartType) -> tuple[KnownMimeType, str]:
                         data_url = io_to_data_url(mime_response, mime_type)
                         return (mime_type, data_url or "")
                     if isinstance(mime_response, str):
-                        if mime_type == "image/svg+xml":
+                        if (
+                            mime_type == "image/svg+xml"
+                            and not altair.renderers.options.get("inline")
+                        ):
                             svg_bytes = mime_response.encode()
                             data_url = io_to_data_url(svg_bytes, mime_type)
                             return (mime_type, data_url or "")

tests/_output/formatters/test_altair_formatters.py

@@ -157,24 +157,34 @@ def test_altair_formatter_mimebundle():
 
 
 @pytest.mark.skipif(not HAS_DEPS, reason="altair not installed")
-def test_altair_formatter_svg():
+@pytest.mark.parametrize(
+    ("inline", "expected"),
+    [
+        (True, "<svg></svg>"),
+        (False, "data:image/svg+xml;base64,PHN2Zz48L3N2Zz4="),
+    ],
+)
+def test_altair_formatter_svg(inline: bool, expected: str):
     AltairFormatter().register()
 
     import altair as alt
 
     # Create a mock chart with a _repr_mimebundle_ method that returns SVG
     mock_chart = alt.Chart(get_data()).mark_point()
-    with patch.object(
-        alt.Chart,
-        "_repr_mimebundle_",
-        return_value={"image/svg+xml": "<svg></svg>"},
+    with (
+        patch.dict(alt.renderers.options, {"inline": inline}),
+        patch.object(
+            alt.Chart,
+            "_repr_mimebundle_",
+            return_value={"image/svg+xml": "<svg></svg>"},
+        ),
     ):
         formatter = get_formatter(mock_chart)
         assert formatter is not None
         mime, content = formatter(mock_chart)
 
         assert mime == "image/svg+xml"
-        assert content == "data:image/svg+xml;base64,PHN2Zz48L3N2Zz4="
+        assert content == expected
 
 
 @pytest.mark.skipif(not HAS_DEPS, reason="altair not installed")