Skip to content

fix: pin pydantic-ai instrumentation version#10239

Merged
Light2Dark merged 2 commits into
marimo-team:mainfrom
aadetya:fix/pydantic-ai-instrumentation-v5
Jul 21, 2026
Merged

fix: pin pydantic-ai instrumentation version#10239
Light2Dark merged 2 commits into
marimo-team:mainfrom
aadetya:fix/pydantic-ai-instrumentation-v5

Conversation

@aadetya

@aadetya aadetya commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

📝 Summary

Closes #10238

This sets the Pydantic-AI instrumentation version to 5 so deferred frontend tool calls are not reported as tracing errors when using older supported Pydantic-AI versions.

I also updated the existing test to make sure Marimo actually passes version=5 when creating the instrumentation settings. Checking only the final value would not catch the same problem on newer Pydantic-AI versions, since they already default to version 5.

Tested with Pydantic-AI 1.107.0 and 2.9.0.

📋 Pre-Review Checklist

✅ Merge Checklist

  • I have read the contributor guidelines.
  • Documentation has been updated where applicable, including docstrings for API changes. No documentation changes were needed here.
  • Tests have been added for the changes made.

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jul 21, 2026 12:25pm

Request Review

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@aadetya

aadetya commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@aadetya
aadetya marked this pull request as ready for review July 20, 2026 06:19
Comment thread marimo/_tracer.py Outdated
@Light2Dark

Copy link
Copy Markdown
Member

you can add a comment to this issue in the test if you want.

@aadetya

aadetya commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Got it, I removed the production comment and moved the explanation to the test, where it clarifies why the explicit version=5 assertion is required.

@Light2Dark
Light2Dark enabled auto-merge (squash) July 21, 2026 14:45

@Light2Dark Light2Dark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll do a small pass to improve the comment, thanks!

@Light2Dark
Light2Dark merged commit 6e18b32 into marimo-team:main Jul 21, 2026
40 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.15-dev41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pydantic-AI tracing marks deferred frontend tools as errors at the supported dependency floor

2 participants