ci: remove hatch and dead code#8971
Conversation
github-actions
Bot
added
the
documentation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR removes Hatch usage and deletes unused Dagger-related code/config, consolidating build steps around uv.
Changes:
- Remove Hatch from tooling/CI and switch ad-hoc wheel builds to
uv build - Migrate
docs/subproject from Hatchling touv_build - Delete the unused Dagger module, config, and skipped Dagger workflows
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Removes hatch from Pixi dependencies. |
pyodide/build_and_serve.py |
Replaces hatch build with uv build for the file-watcher wheel rebuild. |
docs/pyproject.toml |
Switches docs subproject build backend from Hatchling to uv_build. |
dagger/src/main/* |
Removes unused Dagger module code (dead code cleanup). |
dagger/* |
Removes Dagger project metadata/docs/lockfiles. |
dagger.json |
Removes the Dagger module definition. |
.github/workflows/test_*_dagger.yaml.skip |
Removes skipped/unused Dagger workflows. |
.github/workflows/release-prod.yml |
Removes the Hatch install step; relies on uv build. |
| print(f"Change detected: {event.src_path}") # noqa: T201 | ||
| print("Building wheel...") # noqa: T201 | ||
| subprocess.run(["hatch", "build"]) | ||
| subprocess.run(["uv", "build"]) | ||
| print("Wheel built successfully.") # noqa: T201 |
There was a problem hiding this comment.
subprocess.run(["uv", "build"]) is invoked without check=True, so the script will print "Wheel built successfully" even if the build fails (non-zero exit code). Consider setting check=True (or checking the return code and printing stderr) and only printing the success message on success.
| [tool.hatch.build.targets.wheel] | ||
| include = ["blocks.py"] | ||
| [tool.uv.build-backend] | ||
| module-root = "" |
There was a problem hiding this comment.
The docs project is named marimo_docs, but this uv_build config doesn’t specify a module-name. Unlike the root project (which sets module-name = "marimo"), the docs/ project doesn’t have a marimo_docs Python package/module to infer from, so builds/installs of the editable marimo_docs source may fail or omit the intended modules (notably blocks.py, used by mkdocs.yml via blocks:MarimoBlocksExtension). Configure the build backend to explicitly include the correct module(s) (e.g., set module-name appropriately and/or configure includes so blocks.py is installed).
| module-root = "" | |
| module-root = "." | |
| module-name = "blocks" |
This pull request removes all Dagger-related configuration, scripts, and documentation from the codebase. Dagger was previously used for containerized builds and tests, but is no longer needed. The changes include deleting Dagger workflows, configuration files, Python modules, and related documentation. Additionally, the docs build system is switched from Hatch to uv, and the backend build command is updated accordingly.
This pull request removes all Dagger-related configuration, scripts, and documentation from the codebase. Dagger was previously used for containerized builds and tests, but is no longer needed. The changes include deleting Dagger workflows, configuration files, Python modules, and related documentation. Additionally, the docs build system is switched from Hatch to uv, and the backend build command is updated accordingly.