fix(ci): fix TypeError in get_customize_defaults and modernize PHP tags

mariuz · mariuz · commit 64de2a4e09b8 · 2026-02-25T11:34:43.000+02:00
diff --git a/inc/functions.inc.php b/inc/functions.inc.php
@@ -1249,6 +1249,7 @@ function get_customize_cookie_name()
 //
 function get_customize_defaults($useragent)
 {
+    $ie = (isset($useragent) && is_array($useragent) && isset($useragent['ie'])) ? $useragent['ie'] : false;
 
     return array('color' => array('background' => COLOR_BACKGROUND,
         'panel' => COLOR_PANEL,
@@ -1264,7 +1265,7 @@ function get_customize_defaults($useragent)
         'firstrow' => COLOR_FIRSTROW,
         'secondrow' => COLOR_SECONDROW),
         'language' => LANGUAGE,
-        'fontsize' => ($useragent['ie'] ? 8 : 11),
+        'fontsize' => ($ie ? 8 : 11),
         'textarea' => array('cols' => SQL_AREA_COLS,
             'rows' => SQL_AREA_ROWS),
         'iframeheight' => IFRAME_HEIGHT,
diff --git a/views/footer.php b/views/footer.php
@@ -10,7 +10,7 @@
             <tr>
                 <td>
                     <p class="text-muted">
-                        <?= date('Y') ?>
+                        <?php echo date('Y'); ?>
                         -
                         <a href="https://github.com/mariuz/firebirdwebadmin">FirebirdWebAdmin</a>
                         <?php echo VERSION; ?>
@@ -120,10 +120,10 @@ class="col-sm-4 control-label"><?php echo $usr_strings['AskDel']; ?></label>
 <script src="//cdnjs.cloudflare.com/ajax/libs/codemirror/5.52.0/mode/sql/sql.min.js"></script>
 
 <script src="./js/miscellaneous.js" type="text/javascript"></script>
-<?= js_global_variables()
+<?php echo js_global_variables()
 . js_xml_http_request_client()
 . js_request_close_panel()
-. $js_stack
+. $js_stack;
 ?>
 </body>
 </html>
diff --git a/views/header.php b/views/header.php
@@ -1,10 +1,10 @@
 <!doctype html>
 <html lang="en">
 <head>
-    <meta charset="<?= $GLOBALS['charset'] ?>">
+    <meta charset="<?php echo isset($GLOBALS['charset']) ? $GLOBALS['charset'] : 'UTF-8'; ?>">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="viewport" content="width=device-width, initial-scale=1">
-    <title><?= $title ?></title>
+    <title><?php echo $title; ?></title>
 
     <link href="//netdna.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.css" rel="stylesheet">
     <link rel="stylesheet" href="//netdna.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap-theme.css">
diff --git a/views/menu.php b/views/menu.php
@@ -14,7 +14,7 @@
             <a class="navbar-brand" href="#">FirebirdWebAdmin</a>
         </div>
         <div id="navbar" class="navbar-collapse collapse">
-            <?= get_tabmenu_top_fixed($s_page) ?>
+            <?php echo get_tabmenu_top_fixed($s_page); ?>
 			
 			<?php if ($s_connected == true) {
     ?>
@@ -45,8 +45,7 @@
     ?></a></li>
 					
 					<li role="separator" class="divider"></li>
-					<li><a href="logout.php"><?= $button_strings['Logout'];
-    ?></a></li>
+					<li><a href="logout.php"><?php echo $button_strings['Logout']; ?></a></li>
 				  </ul>
 				</li>
 			</ul>
