Add basename support for crawl mode#81
Open
alexlande wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋
I tried out the new crawl mode today, and it's awesome!
My app uses
basenamewith React Router to handle deployment to GitHub pages, so my routes look like/about, but the deployed URLs look like/project-name/docs/about. This broke the crawler, understandably. It generated the pages but put all of them after the index in a nested subdirectory that matched the basename.This change lets you pass in a basename so that the crawler will disregard it, and all of the pages get built correctly. If you're interested in something like this let me know and I can add some tests.