fix: treat a line of only tabs as a blank line between paragraphs#4007
Open
sarathfrancis90 wants to merge 1 commit into
Open
fix: treat a line of only tabs as a blank line between paragraphs#4007sarathfrancis90 wants to merge 1 commit into
sarathfrancis90 wants to merge 1 commit into
Conversation
A line containing only tabs (or tabs mixed with spaces) is a blank line per CommonMark, so it should break a paragraph. The paragraph rule only checked for a spaces-only line ( +\n) in its continuation lookahead, so a tab-only line was swallowed as a lazy continuation and the surrounding text was merged into one paragraph. Widened it to [ \t]+\n to match tabs too.
|
@sarathfrancis90 is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown flavor: CommonMark
A line that's only tabs (or tabs mixed with spaces) is a blank line in CommonMark, so it should separate paragraphs. Marked only treats a spaces-only line as blank, so when the blank line between two paragraphs happens to contain a tab, that line gets swallowed as a lazy continuation and the two paragraphs merge into one.
With a single tab on the middle line:
marked currently returns one paragraph (
<p>foo\tbar</p>) instead of<p>foo</p>\n<p>bar</p>. A space-only middle line already works, which is what made this easy to miss.The paragraph rule's continuation lookahead was checking for
+\n(spaces only); I widened it to[ \t]+\nso a tab-only line counts as blank too. GFM and pedantic paragraphs build on the same base rule, so they pick up the fix as well. Added a spec test undertest/specs/new.Contributor
blank_line_with_tabs)