fix: address pull request review comments

- Fix git describe error handling in release script
- Fix array insertion issue in changelog generation
- Extract version regex pattern as environment variable in release.yml
- Add proper error handling for missing tags

Author: markhallen

Rakefile

@@ -192,7 +192,7 @@ end
 def generate_changelog_for_version(version)
   content = VersionHelper.generate_changelog_for_version(version)
   puts content
-  
+
   # Update CHANGELOG.md if it exists
   if File.exist?('CHANGELOG.md')
     update_changelog_file(version, content)
@@ -227,7 +227,7 @@ end
 def create_changelog_file(version, content)
   changelog_file = 'CHANGELOG.md'
   header = "# Changelog\n\nAll notable changes to this project will be documented in this file.\n\nThe format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),\nand this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).\n\n## [Unreleased]\n\n"
-  
+
   File.write(changelog_file, header + content)
   puts "✅ Created #{changelog_file} with version #{version}"
 end

docs/VERSION_HELPER_REFACTORING.md

@@ -1,6 +1,7 @@
 # Code Refactoring: Extracted Version Helper
 
 ## Problem
+
 The GitHub Actions workflow in `.github/workflows/create-release-pr.yml` contained inline Ruby code that duplicated version bumping logic from the Rakefile:
 
 ```ruby
@@ -13,30 +14,35 @@ NEXT_VERSION=$(ruby -e "
 ```
 
 This created several issues:
+
 - **Code duplication** between Rakefile and GitHub Actions
 - **Maintenance burden** when updating version logic
 - **Fragile inline code** that's hard to test and debug
 - **Poor separation of concerns**
 
 ## Solution
+
 Created a dedicated `VersionHelper` module and CLI script to centralize all version-related logic:
 
 ### 1. New Files Created
 
 #### `lib/version_helper.rb`
+
 - **Centralized version logic** for semantic versioning operations
 - **Conventional commit analysis** for automatic version bump detection
 - **Changelog generation** with proper categorization
 - **Comprehensive error handling** and validation
 
 #### `scripts/version.rb`
+
 - **CLI interface** for version operations
 - **GitHub Actions friendly** with simple command interface
 - **Executable script** that can be called from any environment
 
 ### 2. Key Refactoring Changes
 
 #### Before (Duplicated):
+
 ```ruby
 # In Rakefile
 def bump_version(version, bump_type)
@@ -48,6 +54,7 @@ NEXT_VERSION=$(ruby -e "complex inline code")
 ```
 
 #### After (DRY):
+
 ```ruby
 # In lib/version_helper.rb
 module VersionHelper
@@ -68,11 +75,13 @@ NEXT_VERSION=$(ruby scripts/version.rb next "$RELEASE_TYPE")
 ### 3. Updated Components
 
 #### Rakefile
+
 - **Simplified helper methods** that delegate to VersionHelper
 - **Removed duplicate logic** for commit analysis and version bumping
 - **Enhanced preview task** using centralized version info
 
 #### GitHub Actions Workflow
+
 - **Replaced inline Ruby** with clean CLI script calls
 - **Improved maintainability** with external script dependency
 - **Better error handling** and debugging capabilities
@@ -99,22 +108,27 @@ ruby scripts/version.rb info
 ## Benefits
 
 ### ✅ **Eliminated Code Duplication**
+
 - Single source of truth for version logic
 - Consistent behavior across all tools
 
 ### ✅ **Improved Maintainability**
+
 - Changes only need to be made in one place
 - Easier to test and debug version logic
 
 ### ✅ **Better Separation of Concerns**
+
 - Version logic isolated in dedicated module
 - CLI script provides clean interface
 
 ### ✅ **Enhanced Testability**
+
 - Helper module can be unit tested independently
 - CLI script provides clear interfaces
 
 ### ✅ **GitHub Actions Optimization**
+
 - Cleaner workflow YAML without inline Ruby
 - Better error messages and debugging
 
@@ -139,10 +153,12 @@ ruby scripts/version.rb info
 ## Files Modified
 
 ### New Files
+
 - `lib/version_helper.rb` - Centralized version management module
 - `scripts/version.rb` - CLI interface for version operations
 
 ### Modified Files
+
 - `Rakefile` - Updated to use VersionHelper instead of duplicated logic
 - `.github/workflows/create-release-pr.yml` - Replaced inline Ruby with CLI script calls
 

lib/version_helper.rb

@@ -9,19 +9,17 @@ module VersionHelper
 
   # Bump version based on release type
   def self.bump_version(current_version, release_type)
-    if current_version.nil? || current_version == 'none'
-      return '1.0.0'
-    end
+    return '1.0.0' if current_version.nil? || current_version == 'none'
 
     # Remove 'v' prefix if present
     version_string = current_version.sub(/^v/, '')
-    
+
     match = version_string.match(VERSION_PATTERN)
-    unless match
-      raise "Invalid version format: #{current_version}"
-    end
+    raise "Invalid version format: #{current_version}" unless match
 
-    major, minor, patch = match[1].to_i, match[2].to_i, match[3].to_i
+    major = match[1].to_i
+    minor = match[2].to_i
+    patch = match[3].to_i
 
     case release_type.to_s.downcase
     when 'major'
@@ -39,34 +37,32 @@ def self.bump_version(current_version, release_type)
   def self.current_version
     # Get the latest tag that looks like a version
     latest_tag = `git describe --tags --abbrev=0 --match="v*" 2>/dev/null`.strip
-    
-    if latest_tag.empty? || $?.exitstatus != 0
-      return nil
-    end
+
+    return nil if latest_tag.empty? || $?.exitstatus != 0
 
     latest_tag
   end
 
   # Analyze commits since last version to determine suggested release type
   def self.analyze_commits_for_version_bump(since_ref = nil)
     since_ref ||= current_version
-    
+
     if since_ref.nil?
       # No previous version, suggest minor for initial release
       return 'minor'
     end
 
     # Get commits since the reference
     commits = `git log #{since_ref}..HEAD --oneline --no-merges 2>/dev/null`.strip.split("\n")
-    
+
     return 'patch' if commits.empty?
 
     has_breaking = false
     has_feature = false
 
     commits.each do |commit|
       commit_msg = commit.split(' ', 2)[1] || ''
-      
+
       # Check for breaking changes
       if commit_msg.include?('BREAKING CHANGE') || commit_msg.match(/^[^:]+!:/)
         has_breaking = true
@@ -77,19 +73,19 @@ def self.analyze_commits_for_version_bump(since_ref = nil)
 
     return 'major' if has_breaking
     return 'minor' if has_feature
-    
+
     'patch' # Default for fixes and other changes
   end
 
   # Generate changelog entries for a version
   def self.generate_changelog_for_version(version, since_ref = nil)
     since_ref ||= current_version
-    
-    if since_ref.nil?
-      commits = `git log --oneline --no-merges`.strip.split("\n")
-    else
-      commits = `git log #{since_ref}..HEAD --oneline --no-merges`.strip.split("\n")
-    end
+
+    commits = if since_ref.nil?
+                `git log --oneline --no-merges`.strip.split("\n")
+              else
+                `git log #{since_ref}..HEAD --oneline --no-merges`.strip.split("\n")
+              end
 
     # Categorize commits
     features = []
@@ -121,34 +117,34 @@ def self.generate_changelog_for_version(version, since_ref = nil)
     # Build changelog content
     changelog_content = []
     changelog_content << "## [#{version}] - #{Date.today.strftime('%Y-%m-%d')}"
-    changelog_content << ""
+    changelog_content << ''
 
     unless breaking_changes.empty?
-      changelog_content << "### ⚠️ BREAKING CHANGES"
-      changelog_content << ""
+      changelog_content << '### ⚠️ BREAKING CHANGES'
+      changelog_content << ''
       changelog_content.concat(breaking_changes)
-      changelog_content << ""
+      changelog_content << ''
     end
 
     unless features.empty?
-      changelog_content << "### ✨ Features"
-      changelog_content << ""
+      changelog_content << '### ✨ Features'
+      changelog_content << ''
       changelog_content.concat(features)
-      changelog_content << ""
+      changelog_content << ''
     end
 
     unless fixes.empty?
-      changelog_content << "### 🐛 Bug Fixes"
-      changelog_content << ""
+      changelog_content << '### 🐛 Bug Fixes'
+      changelog_content << ''
       changelog_content.concat(fixes)
-      changelog_content << ""
+      changelog_content << ''
     end
 
     unless other_changes.empty?
-      changelog_content << "### 🔧 Other Changes"
-      changelog_content << ""
+      changelog_content << '### 🔧 Other Changes'
+      changelog_content << ''
       changelog_content.concat(other_changes)
-      changelog_content << ""
+      changelog_content << ''
     end
 
     changelog_content.join("\n")
@@ -157,7 +153,7 @@ def self.generate_changelog_for_version(version, since_ref = nil)
   # Determine the next version based on commits
   def self.determine_next_version(release_type = 'auto')
     current = current_version
-    
+
     if release_type == 'auto'
       suggested_type = analyze_commits_for_version_bump(current)
       bump_version(current, suggested_type)
@@ -174,7 +170,7 @@ def self.version_info
       suggested_type: analyze_commits_for_version_bump(current),
       next_patch: bump_version(current, 'patch'),
       next_minor: bump_version(current, 'minor'),
-      next_major: bump_version(current, 'major')
+      next_major: bump_version(current, 'major'),
     }
   end
 end

scripts/version.rb

@@ -13,7 +13,7 @@
 
 def main
   command = ARGV[0]
-  
+
   case command
   when 'current'
     puts VersionHelper.current_version || 'none'
@@ -31,13 +31,13 @@ def main
     puts "Next major: #{info[:next_major]}"
   else
     puts "Usage: #{$0} <command> [args]"
-    puts ""
-    puts "Commands:"
-    puts "  current           Get current version"
-    puts "  next [type]       Get next version (auto/major/minor/patch)"
-    puts "  bump [type]       Same as next (alias)"
-    puts "  analyze           Analyze commits for suggested release type"
-    puts "  info              Get all version information"
+    puts ''
+    puts 'Commands:'
+    puts '  current           Get current version'
+    puts '  next [type]       Get next version (auto/major/minor/patch)'
+    puts '  bump [type]       Same as next (alias)'
+    puts '  analyze           Analyze commits for suggested release type'
+    puts '  info              Get all version information'
     exit 1
   end
 rescue StandardError => e