Commit c828fb4
committed
Build: Fix Gutenberg build base-url argument passing across platforms.
When building Gutenberg, the `--base-url` argument was forwarded through
`npm run build --`, which passes arguments through a shell layer. The
argument value `includes_url( 'build/' )` contains spaces, parentheses,
and single quotes that could be mangled by shell parsing on some
platforms, causing the generated `constants.php` to lose the trailing
slash in `build_url`.
This invokes `node bin/build.mjs` directly instead, bypassing npm's
shell forwarding entirely. The argument is passed as a single array
element via `spawn`, so it arrives intact regardless of platform.
Props youknowriad, desrosj.
See #64656.
Built from https://develop.svn.wordpress.org/trunk@61679
git-svn-id: http://core.svn.wordpress.org/trunk@60987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
1 parent a4bfbab commit c828fb4
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
0 commit comments