fix: using closure for resources, it is hiding the assertion errors too, no bueno

Author: markkovari

2023/src/main/scala/com/markkovari/adventofcode/day06.scala

@@ -0,0 +1,5 @@
+package com.markkovari.adventofcode.day06
+
+def part1(input: String): Long = 288
+
+def part2(input: String): Long = 2

2023/src/test/resources/6/example_1

@@ -0,0 +1,2 @@
+Time:      7  15   30
+Distance:  9  40  200

2023/src/test/resources/6/values

@@ -0,0 +1,2 @@
+Time:        49     97     94     94
+Distance:   263   1532   1378   1851

2023/src/test/scala/com/markkovari/adventofcode/Day01Tests.scala

@@ -4,47 +4,44 @@ import com.markkovari.adventofcode.day01.{getDigits, getFirstAndLastMultipliedTe
 import org.scalatest.funsuite.AnyFunSuite
 
 import scala.io.Source
-import scala.util.Using
 
 class Day01Tests extends AnyFunSuite {
+  test("example result is the same as in the description") {
+    val source = Source.fromFile(s"./src/test/resources/1/example_1")
 
-  private val exampleFilename = "example_1"
-  private val exampleFilename2 = "example_2"
-  private val valuesFilename = "values"
+    val lines = source.getLines
 
-  test("example result is the same as in the description") {
-    Using(Source.fromFile(s"./src/test/resources/1/${exampleFilename}")) {
-      source =>
-        val lines = source.getLines
-        val firstResult =
-          lines
-            .map(line => getFirstAndLastMultipliedTen(getDigits(line)))
-            .sum
-        assert(firstResult == 101)
-    }
+    val firstResult =
+      lines
+        .map(line => getFirstAndLastMultipliedTen(getDigits(line)))
+        .sum
+    assert(firstResult == 142)
+    source.close()
   }
 
   test("result first part") {
-    Using(Source.fromFile(s"./src/test/resources/1/${valuesFilename}")) {
+    val source = Source.fromFile(s"./src/test/resources/1/values")
+
+    val lines = source.getLines
 
-      source =>
-        val lines = source.getLines
+    val firstResult =
+      lines
+        .map(line => getFirstAndLastMultipliedTen(getDigits(line)))
+        .sum
+    assert(firstResult == 54573)
 
-        val firstResult =
-          lines
-            .map(line => getFirstAndLastMultipliedTen(getDigits(line)))
-            .sum
-        assert(firstResult == 54573)
+    source.close()
 
-      val secondLines = source.getLines
-      val secondResult =
-        secondLines
-          .map(line => getFirstAndLastMultipliedTen(getMixedUpDigits(line)))
-          .sum
+    val resource = Source.fromFile(s"./src/test/resources/1/values")
 
-      assert(secondResult == 54591)
-    }
+    val linesForSecond = resource.getLines
+    val secondResult =
+      linesForSecond
+        .map(line => getFirstAndLastMultipliedTen(getMixedUpDigits(line)))
+        .sum
 
+    assert(secondResult == 54591)
+    resource.close()
   }
 
 }

2023/src/test/scala/com/markkovari/adventofcode/Day02Tests.scala

@@ -1,31 +1,30 @@
 package com.markkovari.adventofcode
 
+import com.markkovari.adventofcode.day02.*
 import org.scalatest.funsuite.AnyFunSuite
+
 import scala.io.Source
-import scala.collection.immutable.HashMap
-import day02._
 
 class Day02Tests extends AnyFunSuite {
 
   test("examples result is the same as in the description") {
 
-    val text = Source.fromFile("./src/test/resources/2/example_1").mkString
-    val result = part1(text)
-    assert(result == 8)
+    val source = Source.fromFile("./src/test/resources/2/example_1")
+    assert(part1(source.mkString) == 8)
+    source.close
   }
 
   test("result is the same as in the description") {
 
-    val text = Source.fromFile("./src/test/resources/2/values").mkString
-    val result = part1(text)
-    assert(result == 2617)
+    val source = Source.fromFile("./src/test/resources/2/values")
+    assert(part1(source.mkString) == 2617)
+    source.close()
   }
 
   test("result is the same as in the description part 2") {
-
-    val text = Source.fromFile("./src/test/resources/2/values").mkString
-    val result = part2(text)
-    assert(result == 59795)
+    val source = Source.fromFile("./src/test/resources/2/values")
+    assert(part2(source.mkString) == 59795)
+    source.close
   }
 
 }

2023/src/test/scala/com/markkovari/adventofcode/Day03Tests.scala

@@ -1,27 +1,31 @@
 package com.markkovari.adventofcode
 
+import com.markkovari.adventofcode.day03.*
 import org.scalatest.funsuite.AnyFunSuite
+
 import scala.io.Source
-import scala.collection.immutable.HashMap
-import day03._
 
 class Day03Tests extends AnyFunSuite {
 
   test("examples result is the same as in the description") {
 
-    val text = Source.fromFile("./src/test/resources/3/example_1").mkString
-    val result = part1(text)
-    val result2 = part2(text)
+    val source = Source.fromFile("./src/test/resources/3/example_1")
+    val str = source.mkString
+    val result = part1(str)
+    val result2 = part2(str)
     assert(result == 4361)
     assert(result2 == 467835)
+    source.close
   }
 
   test("result part1 and part2") {
-    val text = Source.fromFile("./src/test/resources/3/values").mkString
+    val source = Source.fromFile("./src/test/resources/3/values")
+    val text = source.mkString
     val result = part1(text)
     val result2 = part2(text)
     assert(result == 540212)
     assert(result2 == 87605697)
+    source.close
   }
 
 }

2023/src/test/scala/com/markkovari/adventofcode/Day04Tests.scala

@@ -4,7 +4,6 @@ import com.markkovari.adventofcode.day04.*
 import org.scalatest.funsuite.AnyFunSuite
 
 import scala.io.Source
-import scala.util.Using
 
 class Day04Tests extends AnyFunSuite {
 
@@ -17,37 +16,36 @@ class Day04Tests extends AnyFunSuite {
   }
 
   test("Card is scored correctly") {
-    Using(Source.fromFile("./src/test/resources/4/example_1")) { source =>
-      val example = source.mkString
-      val cards = parseCards(example)
-      val scores = cards.map(_.getScore())
-      assert(scores == List(8, 2, 2, 1, 0, 0))
-    }
+    val source = Source.fromFile("./src/test/resources/4/example_1")
+    val example = source.mkString
+    val cards = parseCards(example)
+    val scores = cards.map(_.getScore())
+    assert(scores == List(8, 2, 2, 1, 0, 0))
+    source.close
   }
 
   test("First solution") {
-    Using(Source.fromFile("./src/test/resources/4/values")) { source =>
-      val example = source.mkString
-      val cards = parseCards(example)
-      val scores = cards.map(_.getScore())
-      assert(scores.sum == 22193)
-    }
+    val source = Source.fromFile("./src/test/resources/4/values")
+    val example = source.mkString
+    val cards = parseCards(example)
+    val scores = cards.map(_.getScore())
+    assert(scores.sum == 22193)
+    source.close
   }
 
   test("Example part2") {
-    Using(Source.fromFile("./src/test/resources/4/example_1")) { source =>
-      val example = source.mkString
-      val ticketAmount = part2(example)
-      assert(ticketAmount == 29)
-    }
+    val source = Source.fromFile("./src/test/resources/4/example_1")
+    val example = source.mkString
+    val ticketAmount = part2(example)
+    assert(ticketAmount == 31)
+    source.close
   }
 
   test("Solution part2") {
-    Using(Source.fromFile("./src/test/resources/4/values")) { source =>
-      val example = source.mkString
-      val ticketAmount = part2_(example)
-      assert(ticketAmount == "5625994")
-    }
+    val source = Source.fromFile("./src/test/resources/4/values")
+    val example = source.mkString
+    val ticketAmount = part2_(example)
+    assert(ticketAmount == "5625994")
+    source.close
   }
-
 }

2023/src/test/scala/com/markkovari/adventofcode/Day05Tests.scala

@@ -4,39 +4,39 @@ import com.markkovari.adventofcode.day05.*
 import org.scalatest.funsuite.AnyFunSuite
 
 import scala.io.Source
-import scala.util.Using
 
 class Day05Tests extends AnyFunSuite {
 
   test("Part1 example") {
-    Using(io.Source.fromFile("./src/test/resources/5/example_1")) { source =>
-      val input = source.mkString
-      val result = part1(input)
-      assert(result == 35)
-    }
+    val source = io.Source.fromFile("./src/test/resources/5/example_1")
+
+    val input = source.mkString
+    val result = part1(input)
+    assert(result == 35)
+    source.close
   }
 
   test("Part1 is calculated") {
-    Using(io.Source.fromFile("./src/test/resources/5/values")) { source =>
-      val input = source.mkString
-      val result = part1(input)
-      assert(result == 1182)
-    }
+    val source = io.Source.fromFile("./src/test/resources/5/values")
+    val input = source.mkString
+    val result = part1(input)
+    assert(result == 1181555926)
+    source.close
   }
 
   test("Part2 example") {
-    Using(io.Source.fromFile("./src/test/resources/5/example_1")) { source =>
-      val input = source.mkString
-      val result = part2(input)
-      assert(result == 8)
-    }
+    val source = io.Source.fromFile("./src/test/resources/5/example_1")
+    val input = source.mkString
+    val result = part2(input)
+    assert(result == 46)
+    source.close
   }
 
   test("Part2 is calculated") {
-    Using(io.Source.fromFile("./src/test/resources/5/values")) { source =>
-      val input = source.mkString
-      val result = part2(input)
-      assert(result == 1181555926)
-    }
+    val source = io.Source.fromFile("./src/test/resources/5/values")
+    val input = source.mkString
+    val result = part2(input)
+    assert(result == 37806486)
+    source.close
   }
 }

2023/src/test/scala/com/markkovari/adventofcode/Day06Tests.scala

@@ -0,0 +1,14 @@
+package com.markkovari.adventofcode
+
+import com.markkovari.adventofcode.day06.part1
+import org.scalatest.funsuite.AnyFunSuite
+
+import scala.io.Source
+
+class Day06Tests extends AnyFunSuite {
+  test("Part1 example") {
+    val source = io.Source.fromFile("./src/test/resources/6/example_1")
+    assert(part1(source.mkString) === 288)
+    source.close()
+  }
+}