fix: resolve Go test failures in 2019 and 2024 (#9)

markkovari · claude · markkovari · commit b3884f644f30 · 2025-10-29T19:37:51.000Z
* fix: resolve Go test failures in 2019 and 2024 - Remove unused 'errors' import in 2024/golang/cmd/04.go - Add filepath parameter to readCommands() function in 2019/go/cmd/15 to match test expectations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: replace deprecated drain_filter with stable alternative in 2021/_4 - Remove unstable feature flag #![feature(drain_filter)] - Replace drain_filter with iter_mut + retain pattern - All Rust tests in 2021 now compile and pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: markkovari <kovarimarkofficial@gmail.com>
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -10,25 +10,87 @@ on:
       - main
 
 jobs:
+  detect_changes:
+    runs-on: ubuntu-latest
+    outputs:
+      rust_projects: ${{ steps.filter.outputs.rust_projects }}
+      go_projects: ${{ steps.filter.outputs.go_projects }}
+      csharp_projects: ${{ steps.filter.outputs.csharp_projects }}
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Detect changed projects
+        id: filter
+        run: |
+          # Get changed files
+          if [ "${{ github.event_name }}" == "pull_request" ]; then
+            CHANGED_FILES=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }})
+          else
+            CHANGED_FILES=$(git diff --name-only ${{ github.event.before }} ${{ github.sha }})
+          fi
+
+          echo "Changed files:"
+          echo "$CHANGED_FILES"
+
+          # Define all projects
+          ALL_RUST_PROJECTS=("2015" "2018" "2019/aoc_rust" "2020/01" "2021/_1" "2021/_2" "2021/_3" "2021/_4" "2021/_5" "2021/_6" "2021/_7" "2022")
+          ALL_GO_PROJECTS=("2017" "2019/go" "2020/02" "2024/golang")
+          ALL_CSHARP_PROJECTS=("2021/cs/1" "2021/cs/2")
+
+          # Check for workflow changes - if workflow changed, run all tests
+          if echo "$CHANGED_FILES" | grep -q "^.github/workflows/tests.yml"; then
+            echo "Workflow changed, running all tests"
+            RUST_PROJECTS=$(printf '%s\n' "${ALL_RUST_PROJECTS[@]}" | jq -R . | jq -s -c .)
+            GO_PROJECTS=$(printf '%s\n' "${ALL_GO_PROJECTS[@]}" | jq -R . | jq -s -c .)
+            CSHARP_PROJECTS=$(printf '%s\n' "${ALL_CSHARP_PROJECTS[@]}" | jq -R . | jq -s -c .)
+          else
+            # Detect Rust projects
+            RUST_PROJECTS=()
+            for project in "${ALL_RUST_PROJECTS[@]}"; do
+              if echo "$CHANGED_FILES" | grep -q "^${project}/"; then
+                RUST_PROJECTS+=("$project")
+              fi
+            done
+
+            # Detect Go projects
+            GO_PROJECTS=()
+            for project in "${ALL_GO_PROJECTS[@]}"; do
+              if echo "$CHANGED_FILES" | grep -q "^${project}/"; then
+                GO_PROJECTS+=("$project")
+              fi
+            done
+
+            # Detect C# projects
+            CSHARP_PROJECTS=()
+            for project in "${ALL_CSHARP_PROJECTS[@]}"; do
+              if echo "$CHANGED_FILES" | grep -q "^${project}/"; then
+                CSHARP_PROJECTS+=("$project")
+              fi
+            done
+
+            RUST_PROJECTS=$(printf '%s\n' "${RUST_PROJECTS[@]}" | jq -R . | jq -s -c .)
+            GO_PROJECTS=$(printf '%s\n' "${GO_PROJECTS[@]}" | jq -R . | jq -s -c .)
+            CSHARP_PROJECTS=$(printf '%s\n' "${CSHARP_PROJECTS[@]}" | jq -R . | jq -s -c .)
+          fi
+
+          echo "rust_projects=$RUST_PROJECTS" >> $GITHUB_OUTPUT
+          echo "go_projects=$GO_PROJECTS" >> $GITHUB_OUTPUT
+          echo "csharp_projects=$CSHARP_PROJECTS" >> $GITHUB_OUTPUT
+
+          echo "Rust projects to test: $RUST_PROJECTS"
+          echo "Go projects to test: $GO_PROJECTS"
+          echo "C# projects to test: $CSHARP_PROJECTS"
+
   rust_tests:
+    needs: detect_changes
+    if: needs.detect_changes.outputs.rust_projects != '[]'
     runs-on: ubuntu-latest
     continue-on-error: true
     strategy:
       fail-fast: false
       matrix:
-        project:
-          - 2015
-          - 2018
-          - 2019/aoc_rust
-          - 2020/01
-          - 2021/_1
-          - 2021/_2
-          - 2021/_3
-          - 2021/_4
-          - 2021/_5
-          - 2021/_6
-          - 2021/_7
-          - 2022
+        project: ${{ fromJson(needs.detect_changes.outputs.rust_projects) }}
     steps:
       - uses: actions/checkout@v4
       - name: Install Rust Stable
@@ -53,16 +115,14 @@ jobs:
         working-directory: ${{ matrix.project }}
 
   go_tests:
+    needs: detect_changes
+    if: needs.detect_changes.outputs.go_projects != '[]'
     runs-on: ubuntu-latest
     continue-on-error: true
     strategy:
       fail-fast: false
       matrix:
-        project:
-          - 2017
-          - 2019/go
-          - 2020/02
-          - 2024/golang
+        project: ${{ fromJson(needs.detect_changes.outputs.go_projects) }}
     steps:
       - uses: actions/checkout@v4
       - name: Set up Go
@@ -87,14 +147,14 @@ jobs:
         working-directory: 2024/golang
 
   csharp_tests:
+    needs: detect_changes
+    if: needs.detect_changes.outputs.csharp_projects != '[]'
     runs-on: ubuntu-latest
     continue-on-error: true
     strategy:
       fail-fast: false
       matrix:
-        project:
-          - 2021/cs/1
-          - 2021/cs/2
+        project: ${{ fromJson(needs.detect_changes.outputs.csharp_projects) }}
     steps:
       - uses: actions/checkout@v4
       - name: Set up .NET
diff --git a/2019/go/cmd/15/main.go b/2019/go/cmd/15/main.go
@@ -6,9 +6,9 @@ import (
 	"strings"
 )
 
-func readCommands() ([]int, error) {
+func readCommands(filepath string) ([]int, error) {
 
-	content, err := os.ReadFile("cmd/15/input.data")
+	content, err := os.ReadFile(filepath)
 	if err != nil {
 		return []int{}, err
 	}
@@ -27,7 +27,7 @@ func readCommands() ([]int, error) {
 }
 func main() {
 
-	nums, err := readCommands()
+	nums, err := readCommands("cmd/15/input.data")
 	if err != nil {
 		println("was not able to read")
 	}
diff --git a/2021/_4/src/main.rs b/2021/_4/src/main.rs
@@ -1,4 +1,3 @@
-#![feature(drain_filter)]
 use std::num::ParseIntError;
 use std::str::FromStr;
 
@@ -129,12 +128,8 @@ fn main() {
     let mut found_table_indicies: Vec<usize> = vec![];
     // let tables_length = tables.len();
     for number in choosen_numbers.0 {
-        tables = tables
-            .drain_filter(|table| {
-                table.toggle(number);
-                table.found_full()
-            })
-            .collect();
+        tables.iter_mut().for_each(|table| table.toggle(number));
+        tables.retain(|table| !table.found_full());
         // tables.retain(|table| (*table).found_full())
     }
     // tables.retain(|table| {
diff --git a/2024/golang/cmd/04.go b/2024/golang/cmd/04.go
@@ -2,7 +2,6 @@ package main
 
 import (
 	"bufio"
-	"errors"
 	"fmt"
 	"os"
 	"strings"

Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,9 @@ import (`
`6`	`6`	`"strings"`
`7`	`7`	`)`
`8`	`8`
`9`		`-func readCommands() ([]int, error) {`
	`9`	`+func readCommands(filepath string) ([]int, error) {`
`10`	`10`
`11`		`- content, err := os.ReadFile("cmd/15/input.data")`
	`11`	`+ content, err := os.ReadFile(filepath)`
`12`	`12`	`if err != nil {`
`13`	`13`	`return []int{}, err`
`14`	`14`	`}`
`@@ -27,7 +27,7 @@ func readCommands() ([]int, error) {`
`27`	`27`	`}`
`28`	`28`	`func main() {`
`29`	`29`
`30`		`- nums, err := readCommands()`
	`30`	`+ nums, err := readCommands("cmd/15/input.data")`
`31`	`31`	`if err != nil {`
`32`	`32`	`println("was not able to read")`
`33`	`33`	`}`