Skip to content

fix: resolve Go test failures in 2019 and 2024 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markkovari merged 2 commits into from
Oct 29, 2025
Merged

fix: resolve Go test failures in 2019 and 2024 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eebeb57
fix: resolve Go test failures in 2019 and 2024
markkovari Oct 29, 2025
88d547f
fix: replace deprecated drain_filter with stable alternative in 2021/_4
markkovari Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions 2019/go/cmd/15/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import (
"strings"
)

func readCommands() ([]int, error) {
func readCommands(filepath string) ([]int, error) {

content, err := os.ReadFile("cmd/15/input.data")
content, err := os.ReadFile(filepath)
if err != nil {
return []int{}, err
}
Expand All @@ -27,7 +27,7 @@ func readCommands() ([]int, error) {
}
func main() {

nums, err := readCommands()
nums, err := readCommands("cmd/15/input.data")
if err != nil {
println("was not able to read")
}
Expand Down
9 changes: 2 additions & 7 deletions 2021/_4/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![feature(drain_filter)]
use std::num::ParseIntError;
use std::str::FromStr;

Expand Down Expand Up @@ -129,12 +128,8 @@ fn main() {
let mut found_table_indicies: Vec<usize> = vec![];
// let tables_length = tables.len();
for number in choosen_numbers.0 {
tables = tables
.drain_filter(|table| {
table.toggle(number);
table.found_full()
})
.collect();
tables.iter_mut().for_each(|table| table.toggle(number));
tables.retain(|table| !table.found_full());
// tables.retain(|table| (*table).found_full())
}
// tables.retain(|table| {
Expand Down
1 change: 0 additions & 1 deletion 2024/golang/cmd/04.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package main

import (
"bufio"
"errors"
"fmt"
"os"
"strings"
Expand Down
Loading