Skip to content

MLE-27841 Bumped undertow and ml-gradle#1929

Merged
rjrudin merged 1 commit intodevelopfrom
feature/bd-bump
Apr 1, 2026
Merged

MLE-27841 Bumped undertow and ml-gradle#1929
rjrudin merged 1 commit intodevelopfrom
feature/bd-bump

Conversation

@rjrudin
Copy link
Copy Markdown
Contributor

@rjrudin rjrudin commented Apr 1, 2026

Now using ml-gradle 6.2.0 instead of SNAPSHOT

Now using ml-gradle 6.2.0 instead of SNAPSHOT
Copilot AI review requested due to automatic review settings April 1, 2026 14:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates build tooling and test dependencies to use released (non-SNAPSHOT) MarkLogic Gradle components, and bumps Undertow for the test app.

Changes:

  • Switch test-app from ml-gradle:6.2-SNAPSHOT via buildscript to the com.marklogic.ml-gradle plugin at 6.2.0.
  • Bump Undertow dependencies in test-app to 2.3.24.Final.
  • Update ml-app-deployer test dependency from 6.2-SNAPSHOT to 6.2.0 in both test modules.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test-app/build.gradle Replaces SNAPSHOT ml-gradle buildscript usage with plugin DSL and bumps Undertow versions.
marklogic-client-api/build.gradle Updates ml-app-deployer test dependency to 6.2.0.
marklogic-client-api-functionaltests/build.gradle Updates ml-app-deployer test dependency to 6.2.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +7 to 10
id "com.marklogic.ml-gradle" version "6.2.0"
id "com.github.psxpaul.execfork" version "0.2.2"
}

Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to the plugins { id "com.marklogic.ml-gradle" version "6.2.0" } DSL changes how the plugin is resolved: this uses Gradle's plugin resolution (pluginManagement), not the subprojects.repositories block. Since settings.gradle has no pluginManagement { repositories { ... } }, Gradle will only consult the Gradle Plugin Portal by default; if com.marklogic.ml-gradle is only available via Maven Central/mavenLocal (as the prior buildscript { repositories { mavenCentral(); mavenLocal(); ... } } implied), the :test-app build will fail. Consider adding a pluginManagement.repositories section (e.g., include mavenCentral/mavenLocal) or reverting to a buildscript classpath for this plugin.

Suggested change
id "com.marklogic.ml-gradle" version "6.2.0"
id "com.github.psxpaul.execfork" version "0.2.2"
}
id "com.github.psxpaul.execfork" version "0.2.2"
}
buildscript {
repositories {
mavenLocal()
mavenCentral()
}
dependencies {
classpath "com.marklogic:ml-gradle:6.2.0"
}
}
apply plugin: "com.marklogic.ml-gradle"

Copilot uses AI. Check for mistakes.
@rjrudin rjrudin merged commit 56c9972 into develop Apr 1, 2026
8 of 9 checks passed
@rjrudin rjrudin deleted the feature/bd-bump branch April 1, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants