Conversation
Now using ml-gradle 6.2.0 instead of SNAPSHOT
There was a problem hiding this comment.
Pull request overview
Updates build tooling and test dependencies to use released (non-SNAPSHOT) MarkLogic Gradle components, and bumps Undertow for the test app.
Changes:
- Switch
test-appfromml-gradle:6.2-SNAPSHOTviabuildscriptto thecom.marklogic.ml-gradleplugin at6.2.0. - Bump Undertow dependencies in
test-appto2.3.24.Final. - Update
ml-app-deployertest dependency from6.2-SNAPSHOTto6.2.0in both test modules.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-app/build.gradle | Replaces SNAPSHOT ml-gradle buildscript usage with plugin DSL and bumps Undertow versions. |
| marklogic-client-api/build.gradle | Updates ml-app-deployer test dependency to 6.2.0. |
| marklogic-client-api-functionaltests/build.gradle | Updates ml-app-deployer test dependency to 6.2.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| id "com.marklogic.ml-gradle" version "6.2.0" | ||
| id "com.github.psxpaul.execfork" version "0.2.2" | ||
| } | ||
|
|
There was a problem hiding this comment.
Switching to the plugins { id "com.marklogic.ml-gradle" version "6.2.0" } DSL changes how the plugin is resolved: this uses Gradle's plugin resolution (pluginManagement), not the subprojects.repositories block. Since settings.gradle has no pluginManagement { repositories { ... } }, Gradle will only consult the Gradle Plugin Portal by default; if com.marklogic.ml-gradle is only available via Maven Central/mavenLocal (as the prior buildscript { repositories { mavenCentral(); mavenLocal(); ... } } implied), the :test-app build will fail. Consider adding a pluginManagement.repositories section (e.g., include mavenCentral/mavenLocal) or reverting to a buildscript classpath for this plugin.
| id "com.marklogic.ml-gradle" version "6.2.0" | |
| id "com.github.psxpaul.execfork" version "0.2.2" | |
| } | |
| id "com.github.psxpaul.execfork" version "0.2.2" | |
| } | |
| buildscript { | |
| repositories { | |
| mavenLocal() | |
| mavenCentral() | |
| } | |
| dependencies { | |
| classpath "com.marklogic:ml-gradle:6.2.0" | |
| } | |
| } | |
| apply plugin: "com.marklogic.ml-gradle" |
Now using ml-gradle 6.2.0 instead of SNAPSHOT