Skip to content

Commit 00e66d5

Browse files
committed
SECCMP-1797: Remove unused regex-pattern and fail-if-no-jira-id inputs
These inputs were defined but never wired into the matching logic: - regex-pattern: matching always used hardcoded VALID_KEY-[0-9]+ - fail-if-no-jira-id: script always exits 1 when no ID found Removed the inputs, their env: mappings, local variable assignments, and debug logging to avoid misleading callers. No caller passes these inputs today.
1 parent 902c355 commit 00e66d5

1 file changed

Lines changed: 0 additions & 18 deletions

File tree

.github/workflows/jira-id-check.yml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,6 @@ on:
1616
required: false
1717
type: string
1818
description: 'The PR title to check (for pull_request_target support)'
19-
regex-pattern:
20-
required: false
21-
type: string
22-
description: 'Custom regex pattern to match JIRA IDs (defaults to "[A-Z]+-[0-9]+")'
23-
default: '[A-Z]+-[0-9]+'
24-
fail-if-no-jira-id:
25-
required: false
26-
type: string
27-
description: 'Whether to fail the check if no JIRA ID is found'
28-
default: 'true'
2919
allow-wip:
3020
required: false
3121
type: string
@@ -51,8 +41,6 @@ jobs:
5141
EVENT_PR_TITLE: ${{ github.event.pull_request.title }}
5242
PR_NUMBER: ${{ github.event.pull_request.number }}
5343
GH_REPO: ${{ github.repository }}
54-
INPUT_REGEX_PATTERN: ${{ inputs.regex-pattern }}
55-
INPUT_FAIL_IF_NO_JIRA_ID: ${{ inputs.fail-if-no-jira-id }}
5644
INPUT_ALLOW_WIP: ${{ inputs.allow-wip }}
5745
INPUT_CASE_SENSITIVE: ${{ inputs.case-sensitive }}
5846
run: |
@@ -84,17 +72,11 @@ jobs:
8472
fi
8573
echo "PR Title: $PR_TITLE"
8674
87-
# Set up inputs as environment variables
88-
# JIRA project keys are defined at the organization level
8975
JIRA_PROJECT_KEYS="$ORGANIZATION_JIRA_PROJECT_KEYS"
90-
REGEX_PATTERN="$INPUT_REGEX_PATTERN"
91-
FAIL_IF_NO_JIRA_ID="$INPUT_FAIL_IF_NO_JIRA_ID"
9276
ALLOW_WIP="$INPUT_ALLOW_WIP"
9377
CASE_SENSITIVE="$INPUT_CASE_SENSITIVE"
9478
9579
echo "Using organization-wide JIRA project keys: $JIRA_PROJECT_KEYS"
96-
echo "Using regex pattern: $REGEX_PATTERN"
97-
echo "Fail if no JIRA ID: $FAIL_IF_NO_JIRA_ID"
9880
echo "Allow WIP PRs: $ALLOW_WIP"
9981
echo "Case sensitive: $CASE_SENSITIVE"
10082

0 commit comments

Comments
 (0)