Record two tokenizer defects handed over from the marko backlog - #233
Record two tokenizer defects handed over from the marko backlog#233DylanPiercey wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 34 34
Lines 4270 4270
Branches 793 793
=======================================
Hits 4268 4268
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
WalkthroughAdded documentation for two suspected parser bugs. One report covers silent truncation of unquoted attribute expressions containing 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@agent-feedback/bugs.md`:
- Line 15: Update PARSED_TEXT_CONTENT.parse so a declined CODE.BACK_SLASH
followed by either quote is consumed as text, without relying on quoteCharCode;
update PARSED_STRING.parse to consume a backslash plus the active quoteCharCode
before quote-closing logic. Add fixtures covering escaped quotes in both
text/style content and parsed strings, and assert INVALID_TEMPLATE_STRING is not
emitted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dc479495-b464-4787-a20e-ee87c43ad301
📒 Files selected for processing (1)
agent-feedback/bugs.md
Both were found while working in marko-js/marko and recorded there; triage put the fix in this repo, so they move here rewritten against this repo's source and with checks that run here.
shouldTerminateHtmlAttrValuehas a look-behind for=>but not>=, so<const/positive=input.delta >= 0/>silently truncates with noonError. Separately, a backslash-escaped quote in a parsed-text body opens a string, so\"in a<style>swallows the rest of the file.Removed from marko in marko-js/marko#3714. The ambiguous space-separated
>form stays there — the tokenizer can't distinguish it from a legitimate tag close.