Skip to content

Take over the miscased event attribute suggestion - #583

Merged
DylanPiercey merged 2 commits into
mainfrom
dpiercey-ws-agent-cleanup-dp8z5v
Jul 31, 2026
Merged

Take over the miscased event attribute suggestion#583
DylanPiercey merged 2 commits into
mainfrom
dpiercey-ws-agent-cleanup-dp8z5v

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Found while working in marko-js/marko and recorded there; the fix is in this repo's extractor, so the entry moves here.

The script extractor writes attribute names as quoted string keys, and TypeScript computes an excess-property spelling suggestion only for identifier keys. So <input onKeydown(e){}> reports a bare TS2353 naming no alternative, where an identifier key would give TS2561 "Did you mean to write 'onKeyDown'?".

Removed from marko in marko-js/marko#3714; the cheatsheet half stays there.

@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 53233f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5a161978-8216-4881-873e-6f8226b8349f

📥 Commits

Reviewing files that changed from the base of the PR and between 832e53c and 53233f9.

📒 Files selected for processing (1)
  • agent-feedback/bugs.md

Comment @coderabbitai help to get the list of available commands.

@DylanPiercey
DylanPiercey merged commit 0c2ea1d into main Jul 31, 2026
4 checks passed
@DylanPiercey
DylanPiercey deleted the dpiercey-ws-agent-cleanup-dp8z5v branch July 31, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant