Skip to content

feat: native lazy load imports #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DylanPiercey wants to merge 1 commit into from
Closed

feat: native lazy load imports #3201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 7 additions & 0 deletions .changeset/bold-groups-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"marko": patch
"@marko/runtime-tags": patch
"@marko/compiler": patch
Comment on lines +2 to +4

@coderabbitai coderabbitai Bot May 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use a minor bump for this feature changeset.

This PR introduces new functionality (“native lazy import API”), so patch under-signals the release impact. Please bump these entries to minor to align semver with a feature release.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.changeset/bold-groups-dance.md around lines 2 - 4, Update the changeset to
use a minor version bump for the new feature: change the entries for "marko",
"`@marko/runtime-tags`", and "`@marko/compiler`" from "patch" to "minor" so the
release correctly reflects the new native lazy import API feature.

---

Add support for native lazy import api.
24 changes: 12 additions & 12 deletions .sizes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
{
"name": "*",
"total": {
"min": 21132,
"brotli": 7918
"min": 22354,
"brotli": 8342
}
},
{
Expand All @@ -19,11 +19,11 @@
},
"runtime": {
"min": 4053,
"brotli": 1803
"brotli": 1802
},
"total": {
"min": 4216,
"brotli": 1923
"brotli": 1922
}
},
{
Expand All @@ -34,11 +34,11 @@
},
"runtime": {
"min": 2360,
"brotli": 1225
"brotli": 1228
},
"total": {
"min": 2449,
"brotli": 1304
"brotli": 1307
}
},
{
Expand All @@ -48,12 +48,12 @@
"brotli": 393
},
"runtime": {
"min": 6413,
"brotli": 2825
"min": 6415,
"brotli": 2813
},
"total": {
"min": 7095,
"brotli": 3218
"min": 7097,
"brotli": 3206
}
},
{
Expand All @@ -64,11 +64,11 @@
},
"runtime": {
"min": 2532,
"brotli": 1287
"brotli": 1282
},
"total": {
"min": 2654,
"brotli": 1391
"brotli": 1386
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions .sizes/comments.csr/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// size: 6413 (min) 2825 (brotli)
// size: 6415 (min) 2813 (brotli)
//#region packages/runtime-tags/dist/dom.mjs
let decodeAccessor = (num) =>
(num + (num < 26 ? 10 : num < 962 ? 334 : 11998)).toString(36),
Expand Down Expand Up @@ -144,7 +144,7 @@ function schedule() {
isScheduled || ((isScheduled = 1), queueMicrotask(flushAndWaitFrame));
}
function flushAndWaitFrame() {
(run(), requestAnimationFrame(triggerMacroTask));
(requestAnimationFrame(triggerMacroTask), run());
}
function triggerMacroTask() {
(channel ||
Expand Down
4 changes: 2 additions & 2 deletions .sizes/comments.ssr/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// size: 2532 (min) 1287 (brotli)
// size: 2532 (min) 1282 (brotli)
//#region packages/runtime-tags/dist/dom.mjs
let decodeAccessor = (num) =>
(num + (num < 26 ? 10 : num < 962 ? 334 : 11998)).toString(36),
Expand Down Expand Up @@ -41,7 +41,7 @@ function schedule() {
isScheduled || ((isScheduled = 1), queueMicrotask(flushAndWaitFrame));
}
function flushAndWaitFrame() {
(run(), requestAnimationFrame(triggerMacroTask));
(requestAnimationFrame(triggerMacroTask), run());
}
function triggerMacroTask() {
(channel ||
Expand Down
4 changes: 2 additions & 2 deletions .sizes/counter.csr/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// size: 4053 (min) 1803 (brotli)
// size: 4053 (min) 1802 (brotli)
//#region packages/runtime-tags/dist/dom.mjs
let decodeAccessor = (num) =>
(num + (num < 26 ? 10 : num < 962 ? 334 : 11998)).toString(36),
Expand Down Expand Up @@ -127,7 +127,7 @@ function schedule() {
isScheduled || ((isScheduled = 1), queueMicrotask(flushAndWaitFrame));
}
function flushAndWaitFrame() {
(run(), requestAnimationFrame(triggerMacroTask));
(requestAnimationFrame(triggerMacroTask), run());
}
function triggerMacroTask() {
(channel ||
Expand Down
4 changes: 2 additions & 2 deletions .sizes/counter.ssr/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// size: 2360 (min) 1225 (brotli)
// size: 2360 (min) 1228 (brotli)
//#region packages/runtime-tags/dist/dom.mjs
let decodeAccessor = (num) =>
(num + (num < 26 ? 10 : num < 962 ? 334 : 11998)).toString(36),
Expand Down Expand Up @@ -41,7 +41,7 @@ function schedule() {
isScheduled || ((isScheduled = 1), queueMicrotask(flushAndWaitFrame));
}
function flushAndWaitFrame() {
(run(), requestAnimationFrame(triggerMacroTask));
(requestAnimationFrame(triggerMacroTask), run());
}
function triggerMacroTask() {
(channel ||
Expand Down
Loading
Loading