Skip to content

chore: test-runner and snapshot improvements#3204

Merged
DylanPiercey merged 1 commit into
mainfrom
test-runner-improvements
Jun 5, 2026
Merged

chore: test-runner and snapshot improvements#3204
DylanPiercey merged 1 commit into
mainfrom
test-runner-improvements

Conversation

@DylanPiercey
Copy link
Copy Markdown
Contributor

Description

Pulls some test runner and snapshot improvements from the WIP lazy load branch.

  • Unify ssr/csr test fixture step execution
  • Extract html/bundle size stats into size.json files
  • Improve browser vm script execution and waiting
  • Other minor cleanups

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 5, 2026

⚠️ No Changeset found

Latest commit: 31a2210

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (f7b067e) to head (31a2210).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3204   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         372      372           
  Lines       47322    47322           
  Branches     3387     3387           
=======================================
  Hits        43909    43909           
  Misses       3380     3380           
  Partials       33       33           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR refactors the Marko runtime initialization and resumption mechanism, replacing a single-runtime ID caching scheme with a multi-render cache (curRenders), introduces new async placeholder management helpers, adds a lazy template loading subsystem, reorders scheduler frame coordination, and creates 119+ test fixture files defining size metric expectations for bundle compression validation across interop and main test directories.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: test runner improvements, snapshot handling, and test infrastructure enhancements reflected throughout the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the extraction of size statistics into size.json files, test runner unification, and VM improvements that are evident in the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test-runner-improvements

Comment @coderabbitai help to get the list of available commands and usage tips.

@DylanPiercey DylanPiercey force-pushed the test-runner-improvements branch from ad7c250 to 31a2210 Compare June 5, 2026 16:00
@DylanPiercey DylanPiercey merged commit 821035e into main Jun 5, 2026
9 checks passed
@DylanPiercey DylanPiercey deleted the test-runner-improvements branch June 5, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant