Link <for> branch owners from the serialized branch list instead of per-branch _ props - #3353
Open
DylanPiercey wants to merge 1 commit into
Open
Link <for> branch owners from the serialized branch list instead of per-branch _ props#3353DylanPiercey wants to merge 1 commit into
<for> branch owners from the serialized branch list instead of per-branch _ props#3353DylanPiercey wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 7e7299f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3353 +/- ##
=======================================
Coverage 94.29% 94.30%
=======================================
Files 388 388
Lines 53085 53153 +68
Branches 4237 4240 +3
=======================================
+ Hits 50058 50125 +67
- Misses 2998 3000 +2
+ Partials 29 28 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A marker-free
<for>serializes its branch scopes as a list on the parent, yet each branch also serializes an identical_: _(parent)owner prop — O(n) redundancy for the common "loop body reads ancestor state" shape._.o(ownerId, scopes)); the resume runtime links each branch's owner from it (a serialized owner still wins, matching marker behavior)._prop is elided outright; when the marker reason is runtime-dependent (e.g.of=input.items),_serializes behind that same guard, so marker-off renders drop it and marker-on renders keep today's behavior.Example (
for-tag-static-value-with-closure):Aa:[_(2),…,_(5)]plus four{_:_(1)}fills becomes justAa:_.o(1,[_(2),…,_(5)]).Checklist:
Generated by Claude Code