perf(runtime-tags): stop materializing branch boundary nodes - #3712
Open
DylanPiercey wants to merge 1 commit into
Open
perf(runtime-tags): stop materializing branch boundary nodes#3712DylanPiercey wants to merge 1 commit into
DylanPiercey wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 4f592ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3712 +/- ##
==========================================
+ Coverage 90.34% 90.37% +0.02%
==========================================
Files 414 414
Lines 19746 19786 +40
Branches 3615 3633 +18
==========================================
+ Hits 17840 17881 +41
Misses 1367 1367
+ Partials 539 538 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DylanPiercey
marked this pull request as ready for review
July 30, 2026 21:43
Client rendered templates no longer pad the ends of a template or branch body whose edge is `if`/`for`/dynamic tag content, and resuming a server rendered branch adopts its real edge nodes instead of retaining the start comment and inserting a text node. `fixBranchEdges` keeps owner ranges valid by repairing their endpoints as nested content moves. `<show>`, `<await>` and `<try>` own their anchors — a `<show>` body is inlined into the enclosing scope and the others move their anchors themselves — so the branch chain cannot repair their ranges. They keep their padding and markers, and instead repair their owner's edges when they detach, swap in a placeholder, or resolve.
DylanPiercey
force-pushed
the
dpiercey-ws-marko-comments-optimization-lfdet4
branch
from
July 30, 2026 21:44
e45bdf8 to
4f592ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Control flow boundaries no longer leave permanent nodes behind. Client rendered templates stop padding the ends of a template or branch body whose edge is
if/for/dynamic tag content, and resuming a server rendered branch adopts its real edge nodes rather than retaining the start comment and inserting a text node. A newfixBranchEdgeskeeps owner ranges valid by repairing their endpoints as nested content moves.<show>,<await>and<try>keep their own anchors — a<show>body is inlined into the enclosing scope and the others move their anchors themselves — so they repair their owner's edges rather than being repaired.Costs ~69B brotli of runtime; halves the marker nodes in a resumed page.