Skip to content

chore: update dependencies#131

Merged
DylanPiercey merged 1 commit into
mainfrom
claude/marko-prettier-deps-update-77jo4t
Jul 3, 2026
Merged

chore: update dependencies#131
DylanPiercey merged 1 commit into
mainfrom
claude/marko-prettier-deps-update-77jo4t

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Updates all dependencies to their latest versions and clears the outstanding npm audit advisories.

A few upstream changes needed adapting to:

  • htmljs-parser 5.12 exposes TagType as a const object + type alias rather than an enum, so typeof TagType.* is used where a type is required.

  • @marko/compiler 5.40 types traverseFast.skip as a unique symbol; the precise type is recovered from the visitor signature instead of casting through any.

  • prettier 3.9 now parenthesizes nested conditional types in extends constraints — generic-tag snapshots refreshed accordingly.

  • Requires htmljs-parser ^5.12.1, which fixes a regression (5.11–5.12.0) where an attribute value with a trailing line comment was treated as self-enclosed and leaked past the tag:

    <!-- input -->
    <custom-tag id=("hello" // keep me)/>
    
    <!-- 5.115.12.0 (broken) -->
    <custom-tag id="hello"/> // keep me
    
    <!-- ^5.12.1 (fixed) -->
    <custom-tag id=(
      "hello" // keep me
    )/>

Full suite (484 tests), lint, and build pass; npm audit is clean.


Generated by Claude Code

Bump all dependencies to their latest versions (htmljs-parser 5.12.1,
prettier 3.9, @marko/compiler 5.40, lint-staged 17, @types/node 26,
rolldown 1.1, typescript-eslint 8.62, etc.) and clear the resulting
audit advisories, adapting to breaking changes along the way:

- htmljs-parser 5.12 exposes `TagType` as a const object + type alias
  rather than an enum, so use `typeof TagType.*` where a type is needed.
- @marko/compiler 5.40 types `traverseFast.skip` as a `unique symbol`;
  recover the precise type from the visitor signature.
- Refresh the generic-tag snapshots for prettier 3.9's parenthesization
  of nested conditional types in `extends` constraints.
- Require htmljs-parser ^5.12.1, which fixes attribute values with a
  trailing line comment being treated as self-enclosed and leaking past
  the tag.
@changeset-bot

changeset-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d900ebd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.83%. Comparing base (f34de53) to head (d900ebd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files           8        8           
  Lines         316      316           
  Branches       54       54           
=======================================
  Hits          306      306           
  Misses          4        4           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey
DylanPiercey merged commit 4b9f3ab into main Jul 3, 2026
11 checks passed
@DylanPiercey
DylanPiercey deleted the claude/marko-prettier-deps-update-77jo4t branch July 3, 2026 02:46
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0103f5d7-a930-4223-9107-49a2d618c320

📥 Commits

Reviewing files that changed from the base of the PR and between f34de53 and d900ebd.

⛔ Files ignored due to path filters (4)
  • package-lock.json is excluded by !**/package-lock.json and included by **
  • src/__tests__/fixtures/generic-tag/__snapshots__/auto.expected.marko is excluded by !**/__snapshots__/** and included by **
  • src/__tests__/fixtures/generic-tag/__snapshots__/concise.expected.marko is excluded by !**/__snapshots__/** and included by **
  • src/__tests__/fixtures/generic-tag/__snapshots__/html.expected.marko is excluded by !**/__snapshots__/** and included by **
📒 Files selected for processing (5)
  • .changeset/cool-days-attack.md
  • package.json
  • src/__tests__/index.test.ts
  • src/index.ts
  • src/parser.ts

Walkthrough

This PR bumps the htmljs-parser dependency to ^5.12.1 along with several devDependency versions, accompanied by a changeset describing a fix for attribute-value trailing line comments leaking past closing tags. It also refines TypeScript type annotations for bodyType properties in parser.ts to use typeof TagType members instead of literal types, updates a test's type derivation for traverseFast.skip, and applies cosmetic spacing fixes to for-loop syntax in index.ts without altering behavior.

Changes

Cohort: Dependency update and type refinements

  • Added changeset declaring patch release with htmljs-parser ^5.12.1 requirement
  • Updated package.json dependency and multiple devDependency versions
  • Refined bodyType type annotations in Node.ControlFlowTag, Node.Tag, and Node.AttrTag to use typeof TagType
  • Added explicit type annotation to local bodyType variable in onOpenTagName
  • Updated skip constant typing in test file to derive type from traverseFast signature
  • Reformatted for-loop spacing in index.ts (no behavior change)

Sequence Diagram(s)

Not applicable — changes are limited to dependency version bumps, type annotation refinements, and cosmetic formatting with no new interaction flows.

Estimated code review effort: 2/5 (Low-Medium)

Related issues: None specified

Related PRs: None specified

Suggested labels: dependencies, typescript

Suggested reviewers: None specified


🐰 A hop, a bump, a version tweak,
Types now stricter, none too weak,
Loops re-spaced with tidy care,
htmljs-parser gets fresh air,
Carrots counted, code compiles —
A rabbit's PR, reviewed in style.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: a dependency update, even though it is broad.
Description check ✅ Passed The description is directly about the dependency updates and related fixes in this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/marko-prettier-deps-update-77jo4t

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot mentioned this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant