Add some test for corner cases.

Author: tejaycar

Berksfile.lock

@@ -6,6 +6,6 @@ DEPENDENCIES
     path: test/cookbooks/ssh_test
 
 GRAPH
-  ssh (0.6.6)
+  ssh (0.10.0)
   ssh_test (0.2.0)
     ssh (>= 0.0.0)

libraries/ssh_config_helpers.rb

@@ -17,6 +17,8 @@ def parse_file(path)
         return entries unless ::File.exist?(path)
         name = nil?
         IO.foreach(path) do |line|
+          next if line.match(/^\s*(#|\r?\n|\s*$)/) # skip lines with only comments or whitespace
+
           matchdata = line.match(/^\s*([h|H]ost)(.*$)/)
           if matchdata
             name = matchdata.captures[1].strip
@@ -25,6 +27,10 @@ def parse_file(path)
           end
 
           matchdata = line.match(/^\s*(\w+)(.*$)/)
+          unless matchdata
+            Chef::Log.error("Line |#{line}| does not parse correctly")
+            next
+          end
           entries[name][matchdata.captures[0]] = matchdata.captures[1].strip
         end
         entries

spec/provider_tests/config_spec.rb

@@ -215,4 +215,23 @@
       )
     end
   end
+
+  it 'can handle files with comments in them' do
+    content = []
+    content << '# this is a comment line'
+    content += partial_start
+    allow(IO).to content.reduce(receive(:foreach).with(default_config), :and_yield)
+
+    expect(chef_run).to render_file(default_config).with_content(
+      (common_end + github_and_partial_end).join("\n")
+    )
+  end
+
+  it 'does not duplicate entries' do
+    allow(IO).to github_and_partial_end.reduce(receive(:foreach).with(vagrant_config), :and_yield)
+
+    expect(chef_run).to render_file(default_config).with_content(
+      (common_end + github_and_partial_end).join("\n")
+    )
+  end
 end