Fix incorrect reshape for multi-device evaluation in evaluate_observable#93
Open
glagnese wants to merge 1 commit into
Open
Fix incorrect reshape for multi-device evaluation in evaluate_observable#93glagnese wants to merge 1 commit into
glagnese wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all.
While running simulations on multiple GPUs using pmap, I encountered incorrect behavior in evaluate_observable. The issue comes from a hard-coded reshape(1, ...), which implicitly assumes that only a single device is used.
When more than one device is available, the current implementation reshapes arrays as "reshape(1, -1, L, L)". However, this breaks when more than one device is available. So I propose to add "ndev = global_defs.myDeviceCount" to read the number of available devices and reshape accordingly : "reshape(ndev, -1, ...)"
On the basis of the tests I made this solution leads to the correct expectation values for the desired observables.
Best,
Gianluca Lagnese