Add <AuthLayout> to share layout of login page with register & forgot password pages#10640
Merged
Conversation
erwanMarmelab
approved these changes
Apr 4, 2025
Member
|
The new component is not exported |
erwanMarmelab
approved these changes
Apr 4, 2025
Comment on lines
+55
to
+57
| display: 'flex', | ||
| flexDirection: 'column', | ||
| alignItems: 'center', |
Contributor
There was a problem hiding this comment.
issue: : There aren't many differences with and without. Can you make any other (more visual) changes?
fzaninotto
reviewed
Apr 4, 2025
| 'radial-gradient(circle at 50% 14em, #313264 0%, #00023b 60%, #00023b 100%)', | ||
|
|
||
| [`& .${AuthLayoutClasses.card}`]: { | ||
| minWidth: 300, |
Member
There was a problem hiding this comment.
shouldn't this be a prop passed down to the card instead?
Contributor
Author
There was a problem hiding this comment.
I don't get this comment
Contributor
Author
There was a problem hiding this comment.
Are you confusing Dialog and Card?
fzaninotto
changed the title
<AuthLayout><AuthLayout> to share layout of login page with register & forgot password pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When building several pages linked to authentication, we have to repeat Several elemens between pages.
Solution
How To Test
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature