Fix(logout): avoid an infinite loop when loading the demo apps for the first time#10769
Merged
Fix(logout): avoid an infinite loop when loading the demo apps for the first time#10769
Conversation
ec02f29 to
81f32d7
Compare
…could lead to unexpected behavior while logging out
djhi
approved these changes
Jun 10, 2025
Contributor
djhi
left a comment
There was a problem hiding this comment.
Thanks for the comment too 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The e-commerce demo was rendering a blank page with many redirects to the logout page when loading the page for the first time. After a many seconds, the login form would render due to an
history.pushStateabuse.Solution
Delay the store to avoid a race condition in
useLogoutthat would cause theCoreAdminRoutescomponent to rerender theLogoutOnMountcomponent leading to an infinite loop.How To Test
Start the e-commerce demo with the following command:
The login page should load fast and no warning about
history.pushStateshould be seen in the console.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.