Fix(show/edit): Avoid a redirect loop when useGetOne returns an error in shadcn-admin-kit#10776
Merged
Fix(show/edit): Avoid a redirect loop when useGetOne returns an error in shadcn-admin-kit#10776
Conversation
… in shadcn-admin-kit
djhi
reviewed
Jun 10, 2025
djhi
approved these changes
Jun 11, 2025
This was referenced Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a resource is not found in
shadcn-admin-kit, there is an infinite loop caused by a race condition between the router navigation and the query refreshSolution
Flush sync the navigation in
useEditControlleranduseShowControllerwhen the record fails to be retrieved.How To Test
Perform the test in the
shadcn-admin-kitwith the updated codeAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.